Allow setting otlp protocol for profiler with otel.exporter.otlp.protocol #2090
+40
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
breedx-splk
reviewed
Oct 16, 2024
Comment on lines
+119
to
+121
| return config.getString( | ||
| CONFIG_KEY_PROFILER_OTLP_PROTOCOL, | ||
| config.getString(CONFIG_KEY_OTLP_PROTOCOL, "http/protobuf")); |
breedx-splk
reviewed
Oct 16, 2024
| @@ -82,7 +83,6 @@ Map<String, String> defaultProperties() { | |||
| config.put(CONFIG_KEY_MEMORY_ENABLED, String.valueOf(DEFAULT_MEMORY_ENABLED)); | |||
| config.put(CONFIG_KEY_MEMORY_EVENT_RATE, DEFAULT_MEMORY_EVENT_RATE); | |||
| config.put(CONFIG_KEY_CALL_STACK_INTERVAL, DEFAULT_CALL_STACK_INTERVAL.toMillis() + "ms"); | |||
| config.put(CONFIG_KEY_OTLP_PROTOCOL, "http/protobuf"); | |||
There was a problem hiding this comment.
This makes it a little more challenging for a casual reader to know the default, but I think it's fine.
breedx-splk
approved these changes
Oct 16, 2024
robsunday
reviewed
Oct 17, 2024
| void getOtlpProtocolDefault() { | ||
| String result = | ||
| Configuration.getOtlpProtocol(DefaultConfigProperties.create(Collections.emptyMap())); | ||
| assertEquals(result, "http/protobuf"); |
There was a problem hiding this comment.
Order of arguments should be reversed. Currently assertion error message may be misleading if the assertion fails.
The same applies to all assetEquals calls in this file.
Maybe using assertThat(result).isEqualTo("http/protobuf"); would be little bit more verbose, but on the other hand not confusing.
robsunday
approved these changes
Oct 17, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
otel.exporter.otlp.protocolwhensplunk.profiler.otlp.protocolis not set.