Set cluster_name for host logs too if renameFieldsSck is enabled #837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Up to now the cluster_name field was only set in `resource/logs`. This snippet was only included for the container logs, but not for host logs (files, journald). This change moves the cluster_name field to the `resource` snippet, which is according inline comment used for all things that pass through otel. Fixes signalfx#682
vinzent
force-pushed
the
feature/sck-cluster-name-for-host-logs
branch
from
b294211
to
0c1ca88
Compare
|
@dmitryax added changelog entry. |
dmitryax
approved these changes
Jun 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Up to now the cluster_name field was only set in
resource/logs. This snippet was only included for the container logs, but not for host logs (files, journald).This change moves the cluster_name field to the
resourcesnippet, which is according inline comment used for all things that pass through otel.Fixes #682