Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for writing out new expected results files via env var #1438

Merged

Conversation

jvoravong
Copy link
Contributor

@jvoravong jvoravong commented Sep 9, 2024

  • Make it so new expected test results are generate under the functional_tests/results directory and in the golden file format
  • Use the UPDATE_EXPECTED_RESULTS env var to determine if new expected test results are generated, the env var should default to false.

Copy link
Contributor

@atoulme atoulme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jvoravong jvoravong changed the title Add support for writing out new expected results files via the UPDATE… Add support for writing out new expected results files via env var Sep 9, 2024
@jvoravong jvoravong force-pushed the feature-update-expected-test-results branch 5 times, most recently from 77f0abe to b1fb4d4 Compare September 9, 2024 23:16
@jvoravong jvoravong force-pushed the feature-update-expected-test-results branch from b1fb4d4 to 55c2e6d Compare September 9, 2024 23:21
@jvoravong jvoravong marked this pull request as ready for review September 9, 2024 23:37
@jvoravong jvoravong requested review from a team as code owners September 9, 2024 23:37
@jvoravong jvoravong merged commit 13281f4 into signalfx:main Sep 9, 2024
42 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants