Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Operator: Migrate .Values.operator.instrumentation.spec to .Values.instrumentation #1436

Merged
merged 5 commits into from
Sep 5, 2024
Merged

Operator: Migrate .Values.operator.instrumentation.spec to .Values.instrumentation #1436

merged 5 commits into from
Sep 5, 2024

Conversation

jvoravong
Copy link
Contributor

Description:

  • Update Operator Helm values to migrate .Values.operator.instrumentation.spec to .Values.instrumentation
  • Add unit tests for instrumentation.yaml Helm template code
  • Add migration notes

@jvoravong jvoravong marked this pull request as ready for review September 4, 2024 16:52
@jvoravong jvoravong requested review from a team as code owners September 4, 2024 16:52
dmitryax
dmitryax approved these changes Sep 5, 2024
View reviewed changes
Copy link
Contributor

@dmitryax dmitryax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jvoravong jvoravong merged commit a185657 into main Sep 5, 2024
83 checks passed
@jvoravong jvoravong deleted the otl-2839 branch September 5, 2024 21:04
@github-actions github-actions bot locked and limited conversation to collaborators Sep 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dmitryax dmitryax dmitryax approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jvoravong @dmitryax