Fix memory conversion from different units to MiB #1128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jinja2
commented
Jan 24, 2024
| This helper converts the input value of memory to MiB. | ||
| Input needs to be a valid value as supported by k8s memory resource field. | ||
| */}} | ||
| {{- define "splunk-otel-collector.convertMemToMib" }} |
There was a problem hiding this comment.
The template converts the input to bytes first and then bytes to MiB. Check the unttest file for examples.
atoulme
approved these changes
Jan 24, 2024
jvoravong
reviewed
Jan 24, 2024
jvoravong
approved these changes
Jan 24, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Helm chart cannot convert non-integer values of memory limits to MiB. When a float value, for e.g.
0.5Gi, is set for memory resource, the variableSPLUNK_MEMORY_TOTAL_MIB(used by the collector to set default memory limit) is set to 0. This PR updates the helper function to handle non-integer memory limit values.Link to Splunk idea: <Link to Splunk idea, see https://ideas.splunk.com>
Testing: PR also adds some unittests which checks the generated variable value for correctness.
Documentation: