Await reconnect before job flush (#28)

* wait for a keepalive from the server before re-running jobs on disconnect

* 4.0.19

* jshint fix

* Handle NULL_TYPE and INT_TYPE when parsing binary data batches

* 4.0.20

lib/client/signalflow/request_manager.js

@@ -16,6 +16,7 @@ var SSE = require('sse.js');
 
 
 function RequestManager(endPoint) {
+  var awaitingKeepaliveConfirmation = false;
   var knownComputations = {};
   var requestIdIndex = 0;
   var maxJobCount = 10000;
@@ -53,6 +54,12 @@ function RequestManager(endPoint) {
     var parsedMsg = sfxWSMsgHandler.parseWebSocketMessage(msg, knownComputations);
     if (parsedMsg.event === 'KEEP_ALIVE') {
       lastKeepAliveTime = Date.now();
+      if (awaitingKeepaliveConfirmation) {
+        Object.keys(knownComputations).forEach(function (computation) {
+          knownComputations[computation].streamController.retry();
+        });
+        awaitingKeepaliveConfirmation = false;
+      }
     }
 
     if (parsedMsg.event === 'JOB_START') {
@@ -118,9 +125,7 @@ function RequestManager(endPoint) {
   function reconnect(token) {
     wsConnectionOpen = false;
     authenticate(token);
-    Object.keys(knownComputations).forEach(function (computation) {
-      knownComputations[computation].streamController.retry();
-    });
+    awaitingKeepaliveConfirmation = true;
   }
 
   function authenticate(token) {
@@ -146,7 +151,6 @@ function RequestManager(endPoint) {
         activeSocket.close();
       }
 
-
       activeSocket = new WebSocket(wsEndpoint + '/v2/signalflow/connect');
       activeSocket.binaryType = 'arraybuffer';
       activeSocket.onmessage = onWebSocketMessage;

package.json

@@ -1,6 +1,6 @@
 {
   "name": "signalfx",
-  "version": "4.0.19",
+  "version": "4.0.20",
   "description": "Node.js client library for SignalFx",
   "homepage": "https://signalfx.com",
   "repository": "https://github.com/signalfx/signalfx-nodejs",