-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ci #742
Fix ci #742
Conversation
I do not understand why you are removing .NET5 from the pipeline. We still have limited support for this. |
It was the best TFM to be removed - I wanted to remove one for the space issues. .NET 5.0 was a good candidate because, it was since its release, known as a non-LTS. This makes its less likely that there is still some one using it. Removing .NET Core 2.1 is riskier since it is targeted in the product build itself. If you look where .NET 5.0 was removed in CI it is just from tests, not product build. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for clarification.
Please remove required steps related to .NET 5. Then we should be fine to merge.
Two tests that seem specially flaky: |
Why
Fix CI: failing Linux container integration tests for various reasons, with chief reason being lack of space. This likely broke with the upgrade of the GH runner.
What
Tests
N/A