Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ci #742

Merged
merged 10 commits into from
Oct 18, 2023
Merged

Fix ci #742

merged 10 commits into from
Oct 18, 2023

Conversation

pjanotti
Copy link
Contributor

Why

Fix CI: failing Linux container integration tests for various reasons, with chief reason being lack of space. This likely broke with the upgrade of the GH runner.

What

  • Removed dotnet 5.0 from build.
  • Removed dotnet install for SDK 3.0 and 5.0 on Linux container tests
  • Removed docker images and files to get space on the runner
  • Removed Lambda tests (and related images) since they were taking too much space.

Tests

N/A

@pjanotti pjanotti requested a review from a team as a code owner October 18, 2023 15:03
@pjanotti
Copy link
Contributor Author

@Kielek
Copy link
Contributor

Kielek commented Oct 18, 2023

I do not understand why you are removing .NET5 from the pipeline. We still have limited support for this.

@pjanotti
Copy link
Contributor Author

I do not understand why you are removing .NET5 from the pipeline. We still have limited support for this.

It was the best TFM to be removed - I wanted to remove one for the space issues. .NET 5.0 was a good candidate because, it was since its release, known as a non-LTS. This makes its less likely that there is still some one using it. Removing .NET Core 2.1 is riskier since it is targeted in the product build itself. If you look where .NET 5.0 was removed in CI it is just from tests, not product build.

Copy link
Contributor

@Kielek Kielek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for clarification.
Please remove required steps related to .NET 5. Then we should be fine to merge.

@pjanotti pjanotti requested a review from a team as a code owner October 18, 2023 17:38
@pjanotti
Copy link
Contributor Author

remove required steps related to .NET 5

@Kielek I removed a few references to .NET 5 from dev docs, see dc6692a, let me know if you have something else on your mind. There are other mentions to net5.0, but, in general they aren't for relevant in this context.

@pjanotti
Copy link
Contributor Author

@Kielek Kielek merged commit 73b6960 into signalfx:main Oct 18, 2023
28 checks passed
@pjanotti pjanotti deleted the fix-ci branch October 18, 2023 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants