Use smaller banner msg on destination folder page #735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix SA1516 (blank lines) This used to not work for the file-scoped namespaces, but now does. * Disable instances of SA1402 (multiple types single file) StyleCop used to not enforce this for record types.
RassK
approved these changes
Jul 12, 2023
pellared
approved these changes
Jul 13, 2023
lachmatt
approved these changes
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Reduce redundant message that was overlapping with logo.
What
Replaced the very lengthy and detailed message with a short direct message.
Side note: we only ship the tracer/src/WindowsInstaller but I changed the shared installer for consistency.
Tests
N/A