Remove backup and check options
#546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrews05
force-pushed
the
removeoptions
branch
from
6ed37cc
to
c849c46
Compare
2 tasks
AlexTMjugador
requested changes
Sep 20, 2023
There was a problem hiding this comment.
As per #529 (comment), I'd revert the removal of backup before merging this. Otherwise, I think it's good to go, great work! 🎉
The removal of the check option has been discussed on the related linked issue and I think there is consensus for removing it, given that its functionality can be achieved by cleverly combining other options.
andrews05
force-pushed
the
removeoptions
branch
from
c849c46
to
fa9bddb
Compare
|
@AlexTMjugador Updated with backup removal notice: |
AlexTMjugador
approved these changes
Sep 26, 2023
Pr0methean
pushed a commit
to Pr0methean/oxipng
that referenced
this pull request
Dec 1, 2023
Tidy up the API by removing a couple of options we don't really need. Backup was discussed in shssoichiro#542 Check was discussed in shssoichiro#439 @shssoichiro Just say if you prefer to keep either of these 🙂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tidy up the API by removing a couple of options we don't really need.
Backup was discussed in #542
Check was discussed in #439
@shssoichiro Just say if you prefer to keep either of these 🙂