Ensure --nx --nz disables all optimisations
#543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrews05
changed the title
--nx --nz disables all optimisations
shssoichiro
approved these changes
Sep 2, 2023
Pr0methean
pushed a commit
to Pr0methean/oxipng
that referenced
this pull request
Dec 1, 2023
This PR makes two changes: - `--nz` (`idat_recoding`) now disables all zlib recompression, including iCCP and fDAT chunks. (Perhaps we should rename the option to `zlib_recompression`?) - `--nx` now also disables the default deinterlacing, though it can still be overridden with `-i`. `--nx --nz` does disable all optimisations in the v8 release and we should ensure it continues to do so in the next release. (This is related to discussions around removing the `--check` option.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes two changes:
--nz(idat_recoding) now disables all zlib recompression, including iCCP and fDAT chunks. (Perhaps we should rename the option tozlib_recompression?)--nxnow also disables the default deinterlacing, though it can still be overridden with-i.--nx --nzdoes disable all optimisations in the v8 release and we should ensure it continues to do so in the next release. (This is related to discussions around removing the--checkoption.)