Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't fail recursion on read_dir error #537

Merged
merged 1 commit into from
Jul 31, 2023
Merged

Don't fail recursion on read_dir error #537

merged 1 commit into from
Jul 31, 2023

Conversation

andrews05
Copy link
Collaborator

@andrews05 andrews05 commented Jul 13, 2023 •
edited
Loading

Fixes #170 by printing a warning instead of returning empty.

AlexTMjugador
AlexTMjugador approved these changes Jul 14, 2023
View reviewed changes
Copy link
Collaborator

@AlexTMjugador AlexTMjugador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@shssoichiro
Copy link
Owner

Thanks! I promise I will get caught up on open PRs. 🙂

@shssoichiro shssoichiro merged commit 0288cc3 into shssoichiro:master Jul 31, 2023
11 checks passed
@andrews05 andrews05 deleted the recursive branch August 6, 2023 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexTMjugador AlexTMjugador AlexTMjugador approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Recursive not working on Windows
3 participants
@andrews05 @shssoichiro @AlexTMjugador