Switch from stderrlog to env_logger to resolve security issue with atty #535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexTMjugador
approved these changes
Jul 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
attydependency ofstderrlogis unmaintained with an outstanding security issue that we need to address. @AlexTMjugador has apparently filed a PR withstderrlogto switch tois-terminalbut there doesn't appear to be any movement on it. Instead I thought it might be good to switch toenv_loggerwhich is more flexible, better maintained, and much more widely used.The only difference to the user is some changes to colours:
Info is now uncoloured (was yellow) - I've done this explicitly as oxipng uses it for normal user output
Warn is now yellow (was magenta)
Debug is now blue (was cyan)
Trace is now cyan (was blue)