This repository has been archived by the owner on Dec 21, 2023. It is now read-only.
Show channel messages button on profile screen even if empty #2492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgeavaldez
requested review from
intergalacticspacehighway,
alantoa and
hirbod
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
PR Preview - Storybook on Chromatic |
PR Preview - AppThis pull request preview deployment is now available. Open Details✅ Preview: exp+io.showtime.development://expo-development-client/?url=https://u.expo.dev/45cbf5d5-24fe-4aa6-9580-acf540651abd&channel-name=pr-2492 Comment ID: 1789194884 |
|
@jorgeavaldez I actually did this on purpose. There is no need to show 0 channel messages imho. |
Changed it to this at Alex's request |
hirbod
approved these changes
Nov 1, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
I deleted a channel message locally but it was the only message in the channel. Then it looked like the channel did not exist. I did see it in the channels list though.
This is a problem only because i fixed https://linear.app/showtime/issue/SHOW2-2303/deleted-messages-are-included-in-profile-channel-message-count
Now we can see it:
How
Validate message count is
>= 0to displayTest Plan
Locally and in staging