fix(SW-27151): removes whitespaces from e-Mails

Otherwise they are always validated to false.
shopware5 · Jul 12, 2023 · a20bc5e · a20bc5e
1 parent 2c71ba6
commit a20bc5e
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/engine/Shopware/Controllers/Backend/Base.php b/engine/Shopware/Controllers/Backend/Base.php
@@ -1043,7 +1043,7 @@ public function validateEmailAction()
         $this->Front()->Plugins()->ViewRenderer()->setNoRender();
         $this->Front()->Plugins()->Json()->setRenderer(false);
 
-        $emails = explode(',', (string) $this->Request()->getParam('value', ''));
+        $emails = array_map('trim', explode(',', (string) $this->Request()->getParam('value', '')));
 
         /** @var EmailValidatorInterface $emailValidator */
         $emailValidator = $this->container->get(EmailValidator::class);

diff --git a/tests/Functional/Controllers/Backend/BaseTest.php b/tests/Functional/Controllers/Backend/BaseTest.php
@@ -246,6 +246,10 @@ public function provideEmails(): Generator
             'emails' => '[email protected],[email protected],[email protected]',
             'expectedIsValid' => true,
         ];
+        yield '3 mails with whitespaces shall be valid' => [
+            'emails' => '[email protected] , [email protected] , [email protected]',
+            'expectedIsValid' => true,
+        ];
         yield '3 mail shall be invalid' => [
             'emails' => '[email protected],[email protected],[email protected]||test',
             'expectedIsValid' => false,