Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker build for "headless" VNC server #1446

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

pjfitzgibbons
Copy link
Member

@pjfitzgibbons pjfitzgibbons commented Jun 9, 2017

This Dockerfile can be used to build an image for a "headless" VNC server and fully-running Shoes 4 environment. #1445

To build (in Shoes workspace dir) :
$ docker build -t shoes-dev:vnc .
$ docker run -it -p 5901:5901 -p 6901:6901 shoes-dev:vnc bash

To Run :

  1. Browse to : http://localhost:6901/?password=vncpassword
  2. Start a terminal : Click "Applications Menu" (upper left) => "Terminal Emulator"
  3. Run shoes! : $ bin/shoes sample/simple_form.rb

This is using tag(image name) shoes-dev:vnc locally.

From Docker : (I think?!)
$ docker pull pjfitzgibbons/shoes4-dev:vnc
(run from above)
$ docker run -it -p 5901:5901 -p 6901:6901 pjfitzgibbons/shoes4-dev:vnc bash

Todo :

  • write ONBUILD steps so image can be properly distributed
  • deploy and test image to dockerhub
  • improve startup environment -- possibly switch between VNC and core Shoes bin

@PragTob
Copy link
Member

PragTob commented Jun 15, 2017

👋

Looks cool, thanks for doing this!

Like Jason I have little knowledge of docker so I'll just have to trust you with his and might need to try it out some time :D

What I notocied is that there are a bunch of xfce files etc... do they need to be there? I always thought we could just have a couple of scripts that then make the docker thingy?

Also, great to see you virtually around here 💃

@pjfitzgibbons
Copy link
Member Author

yes xfce is part of the docker environment so it can display the linux desktop (XFCE) via novpn (the web url).
eventually I would modify the Dockerfile so it can be built in standalone-run mode (with latest Shoes built-in) and Developer-mode, with the shoes-repo linked into the docker image as virtual-folder.
I'll probably use this on my local development environment because I usually have several competing and interfering environments on one machine and isolation is bliss.

@jasonrclark
Copy link
Member

Hey @pjfitzgibbons! I'm pushing on getting pre10 finally out the door, but looking forward to cracking this open. Used Docker a ton for server deployment business at work, but this'll be a unique use of it for me.

Couple questions that occur to me:

  • Should we get a shoes org set up on Docker hub for hosting the Docker image if we're intending to share it publicly?
  • Does it make sense to include the stuff here in the main Shoes repo? Not a big problem, but I wondered when I first read through whether a separately hosted image repo + just a Dockerfile in the shoes4 repo to pull from that base image has any attraction. It doesn't seem like we're likely to be changing the Docker/VNC pieces at the same rate as the gems, but don't know if it really matters. Totally cool if it's more convenient here.

Super stoked for this contribution and seeing you back with 👟 !

@jasonrclark
Copy link
Member

Oh, and the build failures are totally for in progress stuff I got stalled on between furoshiki and Shoes... once I get pre10 cut, you'll be able to rebase this to master and everything should be 👌

@jasonrclark
Copy link
Member

Changes are on master that should get the build green again. Feel free to rebase and push at your leisure.

@PragTob
Copy link
Member

PragTob commented Feb 24, 2018

👋

DO we wanna push this forward, otherwise I'd close this!

@PragTob PragTob changed the base branch from master to main July 5, 2020 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants