add unix socket support for prometheus #128
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @shizunge do you mind taking a look? |
|
cc @Bananz0 @JeDaYoshi do you mind taking a look? |
|
I'm not part of the project, so I can't act on it. |
|
gotcha! appreciate the fast response. i see you have contributed here before though - do you have any suggestions or criticisms for this change? |
|
cc @olofvndrhr do you mind taking a look? |
|
I will take a look at this at Sept 19 or 20. |
shizunge
reviewed
Sep 20, 2024
| @@ -87,7 +89,24 @@ func InitPrometheus(prometheusHost, prometheusPort, prometheusEntry string) { | |||
| handler := promhttp.HandlerFor(promReg, promhttp.HandlerOpts{EnableOpenMetrics: true}) | |||
| http.Handle("/"+prometheusEntry, handler) | |||
| go func() { | |||
| glog.Infof("Starting Prometheus on %v:%v, entry point is /%v", prometheusHost, prometheusPort, prometheusEntry) | |||
|
|
|||
| if strings.HasPrefix(prometheusHost, "unix:") { | |||
There was a problem hiding this comment.
Can you move this to a new function?
| if strings.HasPrefix(prometheusHost, "unix:") { | ||
| socketPath := prometheusHost[5:] | ||
| glog.Infof("Starting Prometheus on Unix socket %v, entry point is /%v", socketPath, prometheusEntry) | ||
| os.Remove(socketPath) // allow failure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR allows for listening on a Unix domain socket for prometheus metrics by prefixing the path with
unix:also open to alternative prefixes like
unix/(which is what caddy uses)some of this approach can probably be reused for #112
example usage:
starting endlessh-go
getting metrics