Merge pull request #634 from qu1queee/qu1queee/default_git_branch_fix

Modify default branch behaviour for git repos

docs/build.md

@@ -83,7 +83,7 @@ The `Build` definition supports the following fields:
 A `Build` resource can specify a Git source, together with other parameters like:
 
 - `source.credentials.name` - For private repositories, the name is a reference to an existing secret on the same namespace containing the `ssh` data.
-- `source.revision` - An specific revision to select from the source repository, this can be a commit or branch name.
+- `source.revision` - An specific revision to select from the source repository, this can be a commit or branch name. If not defined, it will fallback to the git repository default branch.
 - `source.contextDir` - For repositories where the source code is not located at the root folder, you can specify this path here. Currently, only supported by `buildah`, `kaniko` and `buildpacks` build strategies.
 
 By default, the Build controller will validate that the Git repository exists. If the validation is not desired, users can define the `build.shipwright.io/verify.repository` annotation with `false`. For example:

pkg/reconciler/buildrun/resources/taskrun.go

@@ -180,7 +180,10 @@ func GenerateTaskRun(
 	strategy buildv1alpha1.BuilderStrategy,
 ) (*v1beta1.TaskRun, error) {
 
-	revision := "master"
+	// Set revision to empty if the field is not specified in the Build.
+	// This will force Tekton Controller to do a git symbolic-link to HEAD
+	// giving back the default branch of the repository
+	revision := ""
 	if build.Spec.Source.Revision != nil {
 		revision = *build.Spec.Source.Revision
 	}

pkg/reconciler/buildrun/resources/taskrun_test.go

@@ -121,7 +121,7 @@ var _ = Describe("GenerateTaskrun", func() {
 
 			namespace = "build-test"
 			contextDir = "src"
-			revision = "master"
+			revision = ""
 			builderImage = &buildv1alpha1.Image{
 				ImageURL: "heroku/buildpacks:18",
 			}