設定画面モーダル作成 #5
Merged
設定画面モーダル作成 #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KobayashiYoh
requested changes
Mar 8, 2024
Comment on lines
+20
to
+29
| static const TextStyle h3BasicBlack = TextStyle( | ||
| fontSize: 12, | ||
| color: AppColors.black, | ||
| fontWeight: FontWeight.w500, | ||
| ); | ||
| static const TextStyle h1ThinBlack = TextStyle( | ||
| fontSize: 17, | ||
| color: AppColors.black, | ||
| fontWeight: FontWeight.w100, | ||
| ); |
There was a problem hiding this comment.
スタイルの定義がデザイナーさんっぽくていいですね👍
Comment on lines
+20
to
+23
| class AppBottomModalSheet extends StatelessWidget { | ||
| final String title; | ||
| final Widget content; | ||
| final bool showBottomDivider; |
There was a problem hiding this comment.
FeedPageでの使い回しを意識できていていいですね👍
Comment on lines
52
to
58
| child: Container( | ||
| padding: | ||
| const EdgeInsets.symmetric(horizontal: 16, vertical: 18), | ||
| child: SingleChildScrollView( | ||
| child: content, | ||
| ), | ||
| ), |
There was a problem hiding this comment.
修正は任意ですが、画面下の文字が切れているのが気になりました。
恐らく、余白設定の方法が原因だと思われます。
There was a problem hiding this comment.
プルリクに添付された画像だけだと気づけなかったのですが、画面上部の余白も切れているので今後修正お願いします。
これ以上長引いてもアレなので、今回はマージします。
Comment on lines
+1
to
+2
| class Texts { | ||
| static const String privacyPolicyText = ''' |
yukik8
reviewed
Mar 11, 2024
KobayashiYoh
approved these changes
Mar 11, 2024
|
LGTMです |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要：設定画面モーダルを作成しました
CLIENT_IDとCLIENT_SECRET
実装した内容：設定画面モーダルを作成しました
UI
動作確認
参考
その他