Feedpage tableViewスクロールキーボードが隠れるようにする、検索結果0件の状態でテキストフィールドを空にしてPullToRefreshする #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azuma502
changed the title
KobayashiYoh
approved these changes
May 28, 2024
Comment on lines
+59
to
+61
| onTap: () { | ||
| FocusScope.of(context).unfocus(); // タップでキーボードを閉じる | ||
| }, |
Comment on lines
+62
to
+68
| child: NotificationListener<ScrollNotification>( | ||
| onNotification: (scrollNotification) { | ||
| if (scrollNotification is ScrollStartNotification) { | ||
| FocusScope.of(context).unfocus(); // スクロール開始でキーボードを閉じる | ||
| } | ||
| return false; | ||
| }, |
There was a problem hiding this comment.
この実装だと、ユーザーは何が起きたのか把握しづらいので、RefreshIndicator等のウィジェットを使ってpull to refreshのUIを表示してください！
今回修正の必要はありませんが、表示するかしないかでだいぶUX変わると思います！
Comment on lines
+79
to
93
| return const Center( | ||
| child: Column( | ||
| children: [ | ||
| SizedBox(height: 228), | ||
| Text( | ||
| '検索にマッチする記事はありませんでした', | ||
| style: AppTextStyles.h2BasicBlack, | ||
| ), | ||
| SizedBox(height: 18), | ||
| Text( | ||
| '検索条件を変えるなどして再度検索をしてください', | ||
| style: AppTextStyles.h3BasicSecondary, | ||
| ) | ||
| ], | ||
| ), |
There was a problem hiding this comment.
インデントが深くなっているので、UIコンポーネントとして切り分けるといいかもしれませんね！
ここも今回修正の必要はありません。
| if (accessToken == null || accessToken.isEmpty) { | ||
| debugPrint('Access token is null or empty'); | ||
| throw Exception('No access token found'); | ||
| } | ||
| return accessToken; | ||
| return accessToken ?? ''; // アクセストークンがなければ空文字を返す |
There was a problem hiding this comment.
ご存じだとは思いますし、今回修正の必要はありませんが、ここは僕も空の文字列よりnullを返す方がいいかもしれないです！
#47 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要
tableViewスクロールキーボードが隠れるようにする、検索結果0件の状態でテキストフィールドを空にしてPullToRefreshする
CLIENT_IDとCLIENT_SECRET
https://drive.google.com/file/d/1eDe853r65nVN0CZR-UD7GrW_24_RE6Sk/view?usp=drive_link
実装した内容
tableViewスクロールキーボードが隠れるようにする、検索結果0件の状態でテキストフィールドを空にしてPullToRefreshする
UI
RPReplay_Final1715852465.MP4
動作確認
RPReplay_Final1715866027.MP4
参考
その他