FeedPage・ページネーション #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
KobayashiYoh
approved these changes
Mar 24, 2024
qiita_app/lib/main.dart
Outdated
Comment on lines
8
to
9
| QiitaRepository.fetchQiitaItems(); | ||
| QiitaRepository.fetchQiitaItems(PaginatedDataTable.defaultRowsPerPage); |
There was a problem hiding this comment.
ビルドの度にこのメソッドが実行されているので、削除しちゃってもいいかもしれないです。
qiita_app/lib/pages/feed_page.dart
Outdated
Comment on lines
28
to
40
| void fetchArticles() async { | ||
| // QiitaRepositoryから記事データを非同期で取得 | ||
| List<Article> fetchedArticles = await QiitaRepository.fetchQiitaItems(); | ||
| // 取得した記事データをステートにセット | ||
| setState(() { | ||
| articles = fetchedArticles; | ||
| }); | ||
| if (!isLoading) { | ||
| setState(() { | ||
| isLoading = true; | ||
| }); | ||
| List<Article> fetchedArticles = | ||
| await QiitaRepository.fetchQiitaItems(currentPage); | ||
| setState(() { | ||
| articles.addAll(fetchedArticles); | ||
| isLoading = false; | ||
| }); | ||
| } | ||
| } |
There was a problem hiding this comment.
isLoadingはこういう風に使うとインデントが深くならずに済みますよ
void fetchArticles() async {
if (isLoading) return;
setState(() {
isLoading = true;
});
List<Article> fetchedArticles =
await QiitaRepository.fetchQiitaItems(currentPage);
setState(() {
articles.addAll(fetchedArticles);
isLoading = false;
});
}
qiita_app/lib/pages/feed_page.dart
Outdated
Comment on lines
42
to
48
| void _scrollListener() { | ||
| if (_scrollController.position.pixels == | ||
| _scrollController.position.maxScrollExtent) { | ||
| // 最下部にスクロールした時に次のページを読み込む | ||
| currentPage++; // 次のページ番号を更新 | ||
| fetchArticles(); | ||
| } |
There was a problem hiding this comment.
難しくて苦戦するポイントですが、しっかり実装できています✨
しかも1日足らずで！
qiita_app/lib/pages/feed_page.dart
Outdated
Comment on lines
71
to
76
| @override | ||
| void dispose() { | ||
| _scrollController.dispose(); // スクロールコントローラーを破棄 | ||
| super.dispose(); | ||
| } | ||
| } |
Comment on lines
27
to
29
| static Future<List<Article>> fetchQiitaItems() async { | ||
| final url = Uri.parse('${Urls.qiitaBaseUrl}/items'); | ||
| static Future<List<Article>> fetchQiitaItems(int page) async { | ||
| final url = Uri.parse('${Urls.qiitaBaseUrl}/items?page=$page'); |
There was a problem hiding this comment.
引数とページネーションについてしっかり理解できています👍
|
しっかり修正できています👍 |
|
LGTMです🎉 何点か気になった箇所があるので下記に記しておきます。 isLoading フラグの制御
|
|
merged👍 別ブランチで以下のissueにも対応してもらえると！ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要
FeedPageのページネーションを実装しました。
CLIENT_IDとCLIENT_SECRET
実装した内容
UI
Screen_recording_20240324_185038.webm
動作確認
参考
その他