Feature/login #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ここの |
|
上のリンクでページに飛べるところにLoginのリンクを追加して、ログインページに簡単に飛べるようにしてみると、ユーザーがもっと使いやすくなると思います！ 
|
|
login.htmlはaccountsフォルダに入れて欲しいです！ |
| # path('<str:username>/', views.UserProfileView.as_view(), name='user_profile'), | ||
| path("login/", auth_views.LoginView.as_view(), name="login"), | ||
| path("logout/", auth_views.LogoutView.as_view(), name="logout"), | ||
| path("profile/", views.UserProfileView.as_view(), name="user_profile"), |
There was a problem hiding this comment.
ここのエンドポイントは最終課題テスト項目要件整理に沿って設定してほしいです！
|
|
||
| LOGIN_REDIRECT_URL = '/tweets/home' | ||
| LOGIN_REDIRECT_URL = "/accounts/profile/" |
| @@ -127,8 +127,8 @@ | |||
|
|
|||
| DEFAULT_AUTO_FIELD = "django.db.models.BigAutoField" | |||
|
|
|||
| LOGIN_URL = '/login' | |||
| LOGIN_URL = "/accounts/login/" | |||
There was a problem hiding this comment.
LOGIN_URL, LOGIN_REDIRECT_URL, LOGOUT_REDIRECT_URLは/〇〇/〇〇の形ではなく、〇〇:〇〇にして欲しいです！
| @@ -7,7 +7,7 @@ | |||
| {{ form.as_p }} <!--← formにはSignupFormのインスタンスが入っている。as_pとすることで、各input要素がpタグで囲まれた状態で表示される。--> | |||
| {% csrf_token %} <!--← csrf_token必須。formタグ内であればどこに書いてもOK --> | |||
| <button type="submit">ユーザー登録</button> | |||
| </form> | |||
| </form> | |||
| self.assertEqual(response.status_code, 200) | ||
| self.assertFalse(form.is_valid()) | ||
| self.assertIn("このフィールドは必須です。", form.errors["username"]) | ||
| self.assertIn("このフィールドは必須です。", form.errors["password"]) |
There was a problem hiding this comment.
ここの下にSESSION_KEYがclient.sessionに含まれているかのチェックを入れて欲しいです！
|
|
||
| # def test_failure_post_with_not_exists_user(self): | ||
| def test_success_post(self): | ||
| User.objects.create_user(username="testuser", password="testpassword") |
|
|
||
| class TestLogoutView(TestCase): | ||
| def test_success_post(self): | ||
| self.client.login(username="testuser", password="testpassword") |
There was a problem hiding this comment.
TestLogoutViewにsetUp関数を作成し、Userモデルの作成とログイン処理をそこに移動して欲しいです！
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
受講生の確認事項
１次レビュアーの確認事項