GitHub ci #2

shichengripple001 · 2022-02-16T08:48:07Z

High Level Overview of Change

Context of Change

Type of Change

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Refactor (non-breaking change that only restructures code)
Tests (You added tests for code that already exists, or your new feature included in this PR)
Documentation Updates
Release

* Increase the visibility of each type's API. * No functional changes.

* These are meant to be used by detail::STVar only and are otherwise error-prone to call.

This is a refactor aimed at cleaning up and simplifying the existing job queue. As of now, all jobs are cancelled at the same time and in the same way, so this commit removes the per-job cancellation token. If the need for such support is demonstrated, support can be re-added. * Revise documentation for ClosureCounter and Workers. * Simplify code, removing unnecessary function arguments and deduplicating expressions * Restructure job handlers to no longer need to pass a job's handle to the job.

Orphaned nodestore directories should only be deleted if the proper nodestore directories are confirmed to exist.

If fast loading is enabled but the last persisted ledger is not entirely on disk, the server would fail to start without manual intervention by the server operator. This commit allows the server to detect this scenario and attempt to automatically recover.

respresent -> represent

* Remove Application & Database dependency in PerfLog. Replace it with a callback passed into the constructor. * Fixes the circular dependency between ripple/nodestore and ripple/basics

@donovanhide

* Update boost version. * Use latest macOS image. * Credit to @donovanhide in #4025 for starting this ball rolling, and inspiring a boost update.

* Allow clio to ask for object successors and predecessors from rippled * Add lower_bound and last_below to SHAMap

* Include a warning message when a newer version is found

* Split Windows prereq jobs to decrease change of timeout. * Generalize "control" commit message keywords from "travis" to "ci". * Tune time and numbar process params.

* Will save significant space and potentially download time for CI caches, and for building multiple configs in a single repo.

* Split that function into a separate file so it can be used in other contexts.

* telLOCAL_ERROR is not new, but it is not used anywhere in the transaction engine, unlike temINVALID. This will make those types of errors distinct and easier to diagnose.

* This intended to future-proof in two ways. 1) so we don't lose the institutional knowledge why we keep using VS2017. 2) if/when the issue is resolved, we'll know it.

* VS19 debug builds DO NOT RUN TESTS. Known issue with those builds, but if it gets fixed, I want to be able to see those tests succeed.

* Simplifies the validation * Note that it will be backward compatible with the "VS 2017 Win64" generator format

* Dump vc environment if parsing fails

docker login with secret

Etest retry

HowardHinnant and others added 30 commits March 1, 2022 11:25

Improve the readability of STBase-derived types

74e6ed1

* Increase the visibility of each type's API. * No functional changes.

Restrict access to the virtual functions move and copy

0c13676

* These are meant to be used by detail::STVar only and are otherwise error-prone to call.

Prefer using a local Sandbox over using the Context's view

df02eb1

Fix deletion of orphan nodestore directories:

06e87e0

Orphaned nodestore directories should only be deleted if the proper nodestore directories are confirmed to exist.

Make gateway_balances admin-only in reporting mode

dc213a4

Use CIDR notation for admin and secure_gateway

8f82b62

Fix typo in ReportingETL.cpp

a529b21

respresent -> represent

Refactor to fix levelization:

0623a40

* Remove Application & Database dependency in PerfLog. Replace it with a callback passed into the constructor. * Fixes the circular dependency between ripple/nodestore and ripple/basics

Fix Travis CI MacOS builds:

255bf82

* Update boost version. * Use latest macOS image. * Credit to @donovanhide in #4025 for starting this ball rolling, and inspiring a boost update.

Proxy validation_quorum when in reporting mode

90326bf

force build with c++17

f326f01

Add successor information to clio ETL messages

11ca9a9

* Allow clio to ask for object successors and predecessors from rippled * Add lower_bound and last_below to SHAMap

Move Beast & fix #include paths

a01cadb

Update boost max to 1.77

297def5

Update cmake_minimum_required to 3.16, Ubuntu 20.04's version

eb57679

Use 3.16 as min cmake

6a8180c

Set version to 1.9.0-b1

1a8eb5e

Update version of vcpkg for Windows builds:

ce8ad3b

* Include a warning message when a newer version is found

Generalize Travis CI config:

1f5c03f

* Split Windows prereq jobs to decrease change of timeout. * Generalize "control" commit message keywords from "travis" to "ci". * Tune time and numbar process params.

Collect all NIH source code into a single folder:

3c91c2b

* Will save significant space and potentially download time for CI caches, and for building multiple configs in a single repo.

Improve Windows Visual Studio CMake build compatibility

647e680

Get the list of manual tests from rippled:

c62723b

* Split that function into a separate file so it can be used in other contexts.

Add missing "deque" headers in a bunch of places

0d0384a

Env unit test RPC errors return a unique result:

00a8768

* telLOCAL_ERROR is not new, but it is not used anywhere in the transaction engine, unlike temINVALID. This will make those types of errors distinct and easier to diagnose.

Add a test case demonstrating VS2019 constexpr char* problem:

cf47913

* This intended to future-proof in two ways. 1) so we don't lose the institutional knowledge why we keep using VS2017. 2) if/when the issue is resolved, we'll know it.

Build and test rippled in Github Actions:

82ff140

* VS19 debug builds DO NOT RUN TESTS. Known issue with those builds, but if it gets fixed, I want to be able to see those tests succeed.

[FOLD] Feedback: Always use the -A cmake architecture switch for VS:

321e296

* Simplifies the validation * Note that it will be backward compatible with the "VS 2017 Win64" generator format

[FOLD] NOW what's going on with Windows builds:

d58b8bb

* Dump vc environment if parsing fails

shichengripple001 force-pushed the github-ci branch 11 times, most recently from f9d4cb6 to 0b118f6 Compare March 28, 2022 01:21

shicheng001sg and others added 13 commits March 28, 2022 09:22

[FOLD] run linux pipeline on self hosted runner

9327271

[FOLD] add pipeline for building rippled builder docker image

0718113

docker login with secret

Verify core file type

a681373

[FOLD] change gcc 8 pipeline to manual trigger

9ec83cf

[FOLD] automatically retry 2 times on error for "Build and Test" step

814c551

Etest retry

[FOLD] test clang-10

b193371

[FOLD] disable image build for centos

cb23fb8

[FOLD] use builder image built from pipeline

7925d31

build image for clang 10

5a9c64e

[FOLD] fix build image pipeline

89eeabc

[FOLD] update builder image for clang 10

08eaf30

[FOLD] fix build image pipeline

5b04af3

[FOLD] run windows/macos pipeline on selfhosted runners

1d7880e

shichengripple001 force-pushed the github-ci branch from 0b118f6 to 1d7880e Compare March 28, 2022 01:22

shicheng001sg and others added 5 commits April 27, 2022 10:36

update docker image

5551bc4

run bash in standard way for windows

545173e

debug

6648483

debug

cfb7bf9

Update README.md

ac7bbc7

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

GitHub ci #2

GitHub ci #2

shichengripple001 commented Feb 16, 2022 •

edited

Loading

GitHub ci #2

Are you sure you want to change the base?

GitHub ci #2

Conversation

shichengripple001 commented Feb 16, 2022 • edited Loading

High Level Overview of Change

Context of Change

Type of Change

shichengripple001 commented Feb 16, 2022 •

edited

Loading