Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This patch updates helpers for ppc64el, s390x and purec_scalar. #591

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

shibatch
Copy link
Owner

It adds explicit typecasting so that C++ compilers can compile the inline headers generated from these helpers.

Checklist

  • I have read the contributing guidelines.
  • I have considered portability of my change across platforms and architectures.
  • I have self-reviewed my code.
  • I have commented my code where necessary.
  • I have updated the documentation accordingly.
  • I have added tests that prove my fix is effective or that my feature works.

What is the purpose of this pull request?

  • This patch addresses the problem where the inline headers for ppc64el, s390x and purec_scalar cannot be compiled with C++ compilers.

What changes did you make?

This patch updates helpers for ppc64el, s390x and purec_scalar.
It adds explicit typecasting so that C++ compilers can compile the inline headers generated from these helpers.

Does this PR relate to any existing issue?

This is part of the patches that implements #574.

It adds explicit typecasting so that C++ compilers can compile the inline headers generated from these helpers.
@blapie
Copy link
Collaborator

blapie commented Oct 14, 2024

Hello! Aren't there intrinsics for power and s390x that could handle these operations in a vector fashion directly?

@shibatch
Copy link
Owner Author

They were not available when I wrote those helpers.
They may be there now though.
I tried everything I could at the time.
Unlike Intel and ARM, reference manuals were not well maintained at that time, so I remember having a lot of trouble.

@blapie
Copy link
Collaborator

blapie commented Oct 14, 2024

Hm, ok. That's what I thought. It would be good to find someone that can look into these in the future.

Feel free to merge, so at least we can use inline headers in C++.

@shibatch shibatch merged commit 686f2ce into master Oct 14, 2024
70 checks passed
@shibatch shibatch deleted the update_helper2 branch October 16, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants