Add CI on Github Actions for macOS #543
Conversation
|
Do we understand what is going on with the cancelled actions? I don't remember cancelling anything, so I retriggerred a run but the re-run got cancelled again. https://github.com/shibatch/sleef/actions/runs/9217334465 |
|
Regarding your message about the cost of macos runners. If I understand the pricing policy correctly, since SLEEF is a public repository we have access to most runners for free, including the macos ones. In this case I'm happy to go an merge this PR, provided all checks pass. |
I also encountered this in my repo, I found that ubuntu-24.04 runner may be faulty, github seems to be AB testing for ubuntu-latest, my workaround is to hardcode it to 22.04 for now.
In fact GHA has a subtle hidden “quota” for public repositories, which can lead to repos being banned if you go too far. In addition, I'm concerned that this may cause some private forks to accidentally use up their limited quota. |
I wonder if we are ever gonna be close to these quota in practice, but I understand the issue with forks. |
Sure, just use schedule. Manual trigger would require repo members to keep an eye on GHA, which I think could be a significant burden. I think the main bottleneck in CI at the moment is QEMU-based testing, so maybe consider split it into separate workflows, run build CI for each commit, and run testing CI periodically. |
|
Thank you for your insight.
Agreed, that is quite a fair price to pay. That is also probably an easier way to monitor resource usage in general, since we know almost exactly what is ran and how often.
Absolutely, we might simply split native and cross jobs into different workflows. Then, use conditionals to run native build+test and cross build on each commit and run cross tests only periodically. Please leave the |
| #- os: "macos-14" | ||
| #arch: "aarch64" |
There was a problem hiding this comment.
Our internal tests pass with apple clang 14 on apple silicon (M1).
Would it be possible to test aarch64 with apple clang 14? I believe it can be installed on macos-13, but maybe maco-14 is still fine.
There was a problem hiding this comment.
Looks like there's a problem with the AppleClang that GHA provides by default. I passed all tests after update it to XCode 15.4. Should I add a new matrix for different XCode versions?
There was a problem hiding this comment.
Brilliant, thanks for checking. Your last version looks good! If a minor compiler update fixes the issue I would not worry too much and probably won't open a new issue.
Mark macOS x86_64 and aarch64 as Tested. Mark i686 and aarch32 as N/A because these ABI are deprecated. Correct "MacOS" to "macOS".
|
Just re-ran the failing workflows as the issue with ubuntu runners seem to have been resolved. |
|
Are you happy for me to merge? |
|
Yes, LGTM. |
|
Thanks again for an outstanding contribution, this is very much appreciated! I'll make sure we have more control over CPU runners usage by re-organising workflows in the upcoming days. |
No description provided.