Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve payment method #35

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Improve payment method #35

wants to merge 2 commits into from

Conversation

beytullahdanis
Copy link

This pull request introduces improvements to the paymentSuccess method, making the code more readable and modular. Changes include:

  • Utilizing isEmpty() for cart check.
  • Extracting logic into separate methods for better readability.
  • Creating helper methods for transaction addition and notification.
  • Elimination of redundant break; statements.
  • Simplification of conditional checks within the loop for better readability.
  • Reduction of unnecessary if else blocks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@beytullahdanis