Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to download/install Windows version for a Linux native game. #476

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Allow to download/install Windows version for a Linux native game. #476

wants to merge 4 commits into from

Conversation

Kzimir
Copy link
Contributor

@Kzimir Kzimir commented Apr 7, 2022

I don't know if you're gonna like this pull request :D
My PR is based on the Makson's PR #317

Why i did this ?

  • Some native games works better with Windows version and Wine.
  • Native games can have an oldest version than Windows like Ruiner or Pathfinder Kingmaker
  • And maybe others thing.

I tried and use it since a long time and it works (Download/Installation and DLC download/installation)

sharkwouter
sharkwouter requested changes Apr 13, 2022
View reviewed changes
Copy link
Owner

@sharkwouter sharkwouter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR! I like this feature and would like to merge it. It just needs a rebase and I have on tiny nitpick. In the settings for installed games, the option probably shouldn't appear.

minigalaxy/api.py Show resolved Hide resolved
@Kzimir Kzimir requested a review from sharkwouter April 15, 2022 17:24
sharkwouter
sharkwouter requested changes May 11, 2022
View reviewed changes
Copy link
Owner

@sharkwouter sharkwouter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I tested it now. It works well. The only issue I have with it at the moment is that 4 tests seem to fail. This should be fixed before merging.

@sharkwouter sharkwouter added this to the 2.0.0 milestone Sep 25, 2022
@sharkwouter
Copy link
Owner

This is a requested feature and I will try to get this working before the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sharkwouter sharkwouter sharkwouter requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Kzimir @sharkwouter