Added Materials as possible targets; fixed useless warnings #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You can now pass a specific material in ".into(material)" Two warnings were also fixed (one Exception not passed into the debug and one boolean never used)
richard-sim
reviewed
Apr 6, 2023
| switch (rendererType) | ||
| { | ||
| case RendererType.renderer: | ||
| Renderer renderer = targetObj.GetComponent<Renderer>(); | ||
|
|
||
| if (renderer == null || renderer.material == null) | ||
| if (renderer == null || renderer.materials[1] == null) |
There was a problem hiding this comment.
This looks like a use-case specific change, and doesn't correspond with the use of renderer.material in the rest of the code below.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added the possibility to pass a specific material (it was very useful to our project) as a parameters in the "into()" function (so you can target, for instance, a specific side of a cube, instead of all 6 sides)
Also, there were two warnings that bothered me in Unity:
These have been fixed.