Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: esbuild loader documentation error #504

Merged
merged 2 commits into from
Jul 13, 2024
Merged

Fix: esbuild loader documentation error #504

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
27f2738
Fix: esbuild loader documentation error
adriangohjw Jul 11, 2024
e235fb2
Update CHANGELOG.md
adriangohjw Jul 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,10 @@ _next_ branch is for v8 changes
## [Unreleased]
Changes since the last non-beta release.

### Changed

- Fix wrong instruction in esbuild loader documentation [PR 504](https://github.com/shakacode/shakapacker/pull/504) by [adriangohjw](https://github.com/adriangohjw)

## [v8.0.1] - July 10, 2024

### Changed
Expand Down
2 changes: 1 addition & 1 deletion docs/using_esbuild_loader.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ To use esbuild as your transpiler today. You need to do two things:
npm install esbuild esbuild-loader
```

2. Add or change `shakapacker_loader` value in your default `shakapacker.yml` config to `esbuild`
2. Add or change `webpack_loader` value in your default `shakapacker.yml` config to `esbuild`
The default configuration of babel is done by using `package.json` to use the file within the `shakapacker` package.

```yml
Expand Down
Loading