Add changelog entry regarding custom bin path removal #490
Conversation
WalkthroughThe recent changes involve removing support for specific environment variables and installation options in Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- CHANGELOG.md (1 hunks)
Additional context used
LanguageTool
CHANGELOG.md
[style] ~1-~1: ‘prior to’ might be wordy. Consider a shorter alternative. (EN_WORDINESS_PREMIUM_PRIOR_TO)
Context: * For the changelog of versions prior to v6, see the [5.x stable branch of rails...
[uncategorized] ~3-~3: You might be missing the article “the” here. (AI_EN_LECTOR_MISSING_DETERMINER_THE)
Context: ...(./docs/v7_upgrade.md) for upgrading to new spelling in version 7. * Please see the...
[style] ~4-~4: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...grading to new spelling in version 7. * Please see the [v6 Upgrade Guide](./docs/v6_up...
[style] ~4-~4: ‘prior to’ might be wordy. Consider a shorter alternative. (EN_WORDINESS_PREMIUM_PRIOR_TO)
Context: ...docs/v6_upgrade.md) to go from versions prior to v6. * [ShakaCode](https://www.shakacode...
[style] ~31-~31: ‘prior to’ might be wordy. Consider a shorter alternative. (EN_WORDINESS_PREMIUM_PRIOR_TO)
Context: ...This returns to the Webpacker behaviour prior to the aborted Webpacker v6. - Remove `re...
[style] ~54-~54: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...G-Rath. - Removehttpsoption forwebpack-dev-server...
[style] ~56-~56: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...G-Rath. - Removeverify_file_existancemethod [PR 446]...
[uncategorized] ~66-~66: You might be missing the article “the” here. (AI_EN_LECTOR_MISSING_DETERMINER_THE)
Context: ...ps://github.com/paypro-leon). - RemoveisArrayutility (just use `Array.isArra...
[uncategorized] ~73-~73: Use a comma before ‘but’ if it connects two independent clauses (unless they are closely connected and short). (COMMA_COMPOUND_SENTENCE_2)
Context: ...ad of errors when compilation is success but stderr is not empty. [PR 416](https://g...
[grammar] ~76-~76: You’ve repeated a verb. Did you mean to only write one of them? (REPEATED_VERBS)
Context: ...G-Rath](https://github.com/g-rath) ### Removed - Removes dependency ongloblibrary. [PR 435](...
[uncategorized] ~77-~77: You might be missing the article “the” here. (AI_EN_LECTOR_MISSING_DETERMINER_THE)
Context: ...h) ### Removed - Removes dependency ongloblibrary. [PR 435](https://github.c...
[uncategorized] ~82-~82: A comma might be missing here. (AI_EN_LECTOR_MISSING_PUNCTUATION_COMMA)
Context: ...racz](https://github.com/tomdracz). Previously this could have been ignored in few cod...
[uncategorized] ~82-~82: You might be missing the article “a” here. (AI_EN_LECTOR_MISSING_DETERMINER_A)
Context: ...viously this could have been ignored in few code branches, especially when checking...
[style] ~119-~119: Some style guides suggest that commas should set off the year in a month-day-year date. (MISSING_COMMA_AFTER_YEAR)
Context: ...acker/pull/363). ## [v7.0.3] - July 7, 2023 ### Fixed - Fixed commands execution fo...
[duplication] ~120-~120: Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Context: ...l/363). ## [v7.0.3] - July 7, 2023 ### Fixed - Fixed commands execution for projects with sp...
[style] ~123-~123: Some style guides suggest that commas should set off the year in a month-day-year date. (MISSING_COMMA_AFTER_YEAR)
Context: ...b.com/kukicola). ## [v7.0.2] - July 3, 2023 ### Fixed - Fixed creation of assets:pr...
[duplication] ~124-~124: Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Context: ...icola). ## [v7.0.2] - July 3, 2023 ### Fixed - Fixed creation of assets:precompile if it is ...
[style] ~127-~127: Some style guides suggest that commas should set off the year in a month-day-year date. (MISSING_COMMA_AFTER_YEAR)
Context: ...com/ahangarha). ## [v7.0.1] - June 27, 2023 ### Fixed - Fixed the condition for sho...
[duplication] ~128-~128: Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Context: ...arha). ## [v7.0.1] - June 27, 2023 ### Fixed - Fixed the condition for showing warning for s...
[style] ~131-~131: Some style guides suggest that commas should set off the year in a month-day-year date. (MISSING_COMMA_AFTER_YEAR)
Context: ...com/ahangarha). ## [v7.0.0] - June 23, 2023 ### Breaking changes - Removes defaults...
[uncategorized] ~135-~135: A comma might be missing here. (AI_EN_LECTOR_MISSING_PUNCTUATION_COMMA)
Context: ...ery file in the codebase was treated as TSX leading to potential issues. This has b...
[uncategorized] ~135-~135: You might be missing the article “the” here. (AI_EN_LECTOR_MISSING_DETERMINER_THE)
Context: ...s. This has been removed and returns to sensible default of the preset which is to figur...
[uncategorized] ~135-~135: A comma might be missing here. (AI_EN_LECTOR_MISSING_PUNCTUATION_COMMA)
Context: ... and returns to sensible default of the preset which is to figure out the file type fr...
[uncategorized] ~135-~135: A comma might be missing here. (AI_EN_LECTOR_MISSING_PUNCTUATION_COMMA)
Context: ...is change might affect generated output however so it is marked as breaking. - Export ...
[uncategorized] ~154-~154: You might be missing the article “the” here. (AI_EN_LECTOR_MISSING_DETERMINER_THE)
Context: ...ct requirements. For more detail, check webpack documentation. Thehttpsentry can be...
[style] ~159-~159: ‘Prior to’ might be wordy. Consider a shorter alternative. (EN_WORDINESS_PREMIUM_PRIOR_TO)
Context: ...dracz](https://github.com/tomdracz). Prior to this change, top level directory of sta...
[uncategorized] ~159-~159: If this is a compound adjective that modifies the following noun, use a hyphen. (EN_COMPOUND_ADJECTIVE_INTERNAL)
Context: ...com/tomdracz). Prior to this change, top level directory of static assets like images ...
[uncategorized] ~161-~161: If this is a compound adjective that modifies the following noun, use a hyphen. (EN_COMPOUND_ADJECTIVE_INTERNAL)
Context: ...tic/image.jpg")`. Going forward, the top level directory of static files will be retai...
[uncategorized] ~161-~161: Use a comma before ‘so’ if it connects two independent clauses (unless they are closely connected and short). (COMMA_COMPOUND_SENTENCE_2)
Context: ...rectory of static files will be retained so this will necessitate the update of fil...
[uncategorized] ~166-~166: You might be missing the article “a” here. (AI_EN_LECTOR_MISSING_DETERMINER_A)
Context: ... make it possible to have projects with mix of JS and TS code [PR 273](https://gith...
[uncategorized] ~168-~168: A comma might be missing here. (AI_EN_LECTOR_MISSING_PUNCTUATION_COMMA)
Context: ...ery file in the codebase was treated as TSX leading to potential issues. This has b...
[uncategorized] ~168-~168: You might be missing the article “the” here. (AI_EN_LECTOR_MISSING_DETERMINER_THE)
Context: ...s. This has been removed and returns to sensible default of the preset which is to figur...
[uncategorized] ~168-~168: A comma might be missing here. (AI_EN_LECTOR_MISSING_PUNCTUATION_COMMA)
Context: ... and returns to sensible default of the preset which is to figure out the file type fr...
[uncategorized] ~168-~168: A comma might be missing here. (AI_EN_LECTOR_MISSING_PUNCTUATION_COMMA)
Context: ...is change might affect generated output however so it is marked as breaking. - Fixed R...
[grammar] ~172-~172: You’ve repeated a verb. Did you mean to only write one of them? (REPEATED_VERBS)
Context: ...arha](https://github.com/ahangarha) ### Removed - Remove redundant enhancement for precompile ta...
[uncategorized] ~174-~174: You might be missing the article “the” here. (AI_EN_LECTOR_MISSING_DETERMINER_THE)
Context: ...https://github.com/ahangarha). - Remove deprecatedcheck_yarn_integrityfrom `Shakapacke...
[style] ~176-~176: Some style guides suggest that commas should set off the year in a month-day-year date. (MISSING_COMMA_AFTER_YEAR)
Context: ...com/ahangarha). ## [v6.6.0] - March 7, 2023 ### Improved - Allow configuration of w...
[style] ~180-~180: Some style guides suggest that commas should set off the year in a month-day-year date. (MISSING_COMMA_AFTER_YEAR)
Context: ...alecslupu). ## [v6.5.6] - February 11, 2023 ### Fixed - Fixed failing to update `bi...
[duplication] ~181-~181: Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Context: ...). ## [v6.5.6] - February 11, 2023 ### Fixed - Fixed failing to updatebin/setupfile due ...
[uncategorized] ~186-~186: You might be missing the article “the” here. (AI_EN_LECTOR_MISSING_DETERMINER_THE)
Context: .... Allows to move an entry to the top of queue. Handy when calling from the layout to ...
[style] ~199-~199: Some style guides suggest that commas should set off the year in a month-day-year date. (MISSING_COMMA_AFTER_YEAR)
Context: ...m/tagliala). ## [v6.5.4] - November 4, 2022 ### Fixed - Fixed regression caused by ...
[duplication] ~200-~200: Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Context: ...a). ## [v6.5.4] - November 4, 2022 ### Fixed - Fixed regression caused by 6.5.3. PR #192 int...
[uncategorized] ~201-~201: This verb does not appear to agree with the subject. Consider using a different form. (AI_EN_LECTOR_REPLACEMENT_VERB_AGREEMENT)
Context: ...xed regression caused by 6.5.3. PR #192 introduce extra split() call. [PR 202](https://gi...
[style] ~233-~233: Some style guides suggest that commas should set off the year in a month-day-year date. (MISSING_COMMA_AFTER_YEAR)
Context: ....com/pulkitkkr). ## [v6.5.0] - July 4, 2022 ### Added - `append_stylesheet_pack_tag...
[style] ~240-~240: Some style guides suggest that commas should set off the year in a month-day-year date. (MISSING_COMMA_AFTER_YEAR)
Context: ...ub.com/artemave) ## [v6.4.1] - June 5, 2022 ### Fixed - Restores automatic installa...
[style] ~248-~248: Some style guides suggest that commas should set off the year in a month-day-year date. (MISSING_COMMA_AFTER_YEAR)
Context: ...b.com/tomdracz). ## [v6.4.0] - June 2, 2022 ### Fixed - Fixed [Issue 123: Rails 7.0...
[duplication] ~249-~249: Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Context: ...dracz). ## [v6.4.0] - June 2, 2022 ### Fixed - Fixed [Issue 123: Rails 7.0.3 - Webpacker con...
[style] ~253-~253: ‘prior to’ might be wordy. Consider a shorter alternative. (EN_WORDINESS_PREMIUM_PRIOR_TO)
Context: ...se nested entries. This was the default prior to v6.0. Because entries maybe generated, ...
[uncategorized] ~258-~258: A comma might be missing here. (AI_EN_LECTOR_MISSING_PUNCTUATION_COMMA)
Context: ...lled before asset precompilation. Going forward you will need to ensure these packages ...
[uncategorized] ~258-~258: If this is a question, use a question mark. (QUESTION_MARK)
Context: ...tasks/yarn.rake) in your own application. ## [v6.3.0] - May 19, 2022 ### Improv...
[style] ~275-~275: The phrase “a variety of” may be wordy. To make your writing clearer, consider replacing it. (A_VARIETY_OF)
Context: ...e mode can affect how your code runs in a variety of ways, but in newer versions of Babel it...
[grammar] ~279-~279: You’ve repeated a verb. Did you mean to only write one of them? (REPEATED_VERBS)
Context: ... change probably won't affect you. ### Added - Addswebpacker_precompilesetting to `webp...
[uncategorized] ~280-~280: You might be missing the article “the” here. (AI_EN_LECTOR_MISSING_DETERMINER_THE)
Context: ...olling precompile behaviour, similar to existingENV["WEBPACKER_PRECOMPILE"]variable....
[uncategorized] ~286-~286: You might be missing the article “the” here. (AI_EN_LECTOR_MISSING_DETERMINER_THE)
Context: ...m/tomdracz). Rather than calculating SHA digest of all the files in the paths wa...
[grammar] ~286-~286: The modal verb ‘will’ requires the verb’s base form. (MD_BASEFORM)
Context: ...timestamp will be checked together will timestamps of all files and directories inside of ...
[style] ~293-~293: Some style guides suggest that commas should set off the year in a month-day-year date. (MISSING_COMMA_AFTER_YEAR)
Context: ...com/tomdracz). ## [v6.2.1] - April 15, 2022 ### Fixed - Put back config.public_mani...
[uncategorized] ~307-~307: The abbreviation “e.g.” (= for example) requires two periods. (E_G)
Context: ...ple invocations of stylesheet_pack_tag (eg for a regular stylesheet & a print styl...
[style] ~315-~315: Some style guides suggest that commas should set off the year in a month-day-year date. (MISSING_COMMA_AFTER_YEAR)
Context: ...m/tomdracz). ## [v6.1.0] - February 4, 2022 ### Added - Support for SWC loader. [PR...
[style] ~322-~322: Some style guides suggest that commas should set off the year in a month-day-year date. (MISSING_COMMA_AFTER_YEAR)
Context: .../pull/2802). ## [v6.0.2] - January 25, 2022 ### Improved - Fix incorrect command na...
[style] ~326-~326: Some style guides suggest that commas should set off the year in a month-day-year date. (MISSING_COMMA_AFTER_YEAR)
Context: ...tricknotes). ## [v6.0.1] - January 24, 2022 ### Improved - PR #21 removed pnp-webpa...
[uncategorized] ~334-~334: You might be missing the article “the” here. (AI_EN_LECTOR_MISSING_DETERMINER_THE)
Context: ...(https://github.com/tomdracz). - Remove automatic addition of node_modules into rails ass...
[uncategorized] ~359-~359: Use a comma before ‘or’ if it connects two independent clauses (unless they are closely connected and short). (COMMA_COMPOUND_SENTENCE)
Context: ...renvironment.js, this must be removed or you will receive an error (`Item nodeMo...
[uncategorized] ~360-~360: You might be missing the article “the” here. (AI_EN_LECTOR_MISSING_DETERMINER_THE)
Context: ...ck-dev-server is used withhmr: true. JS package exportsinliningCss. This is ...
Markdownlint
CHANGELOG.md
15-15: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
17-17: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
25-25: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
27-27: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
31-31: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
33-33: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
35-35: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
39-39: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
43-43: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
50-50: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
52-52: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
54-54: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
56-56: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
58-58: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
60-60: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
62-62: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
64-64: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
66-66: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
68-68: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
73-73: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
74-74: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
77-77: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
80-80: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
87-87: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
92-92: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
97-97: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
98-98: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
99-99: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
102-102: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
103-103: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
104-104: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
105-105: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
108-108: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
113-113: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
116-116: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
117-117: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
121-121: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
125-125: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
129-129: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
133-133: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
137-137: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
142-142: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
143-143: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
144-144: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
145-145: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
148-148: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
152-152: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
153-153: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
154-154: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
155-155: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
157-157: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
164-164: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
165-165: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
166-166: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
170-170: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
171-171: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
173-173: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
174-174: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
178-178: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
182-182: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
184-184: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
186-186: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
188-188: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
189-189: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
190-190: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
195-195: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
196-196: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
197-197: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
201-201: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
206-206: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
207-207: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
216-216: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
225-225: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
228-228: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
229-229: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
230-230: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
231-231: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
235-235: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
238-238: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
242-242: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
246-246: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
250-250: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
253-253: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
256-256: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
258-258: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
263-263: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
266-266: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
273-273: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
280-280: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
281-281: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
284-284: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
290-290: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
291-291: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
295-295: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
300-300: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
301-301: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
302-302: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
303-303: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
306-306: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
307-307: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
308-308: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
313-313: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
317-317: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
320-320: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
324-324: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
328-328: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
333-333: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
334-334: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
335-335: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
340-340: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
341-341: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
342-342: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
345-345: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
347-347: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
352-352: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
359-359: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
360-360: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
361-361: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
362-362: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
363-363: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
364-364: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
365-365: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
366-366: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
369-369: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
370-370: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
371-371: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
372-372: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
337-337: Expected: 1; Actual: 2 (MD012, no-multiple-blanks)
Multiple consecutive blank lines
351-351: Expected: 1; Actual: 2 (MD012, no-multiple-blanks)
Multiple consecutive blank lines
9-9: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
10-10: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
10-10: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
72-72: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
76-76: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
79-79: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
86-86: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
91-91: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
96-96: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
101-101: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
107-107: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
112-112: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
115-115: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
119-119: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
120-120: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
120-120: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
123-123: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
124-124: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
124-124: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
127-127: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
128-128: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
128-128: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
131-131: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
132-132: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
132-132: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
141-141: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
147-147: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
163-163: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
172-172: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
172-172: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
176-176: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
177-177: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
177-177: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
180-180: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
181-181: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
181-181: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
194-194: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
199-199: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
200-200: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
200-200: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
205-205: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
212-212: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
215-215: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
224-224: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
227-227: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
233-233: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
234-234: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
234-234: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
237-237: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
240-240: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
241-241: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
241-241: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
248-248: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
249-249: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
249-249: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
252-252: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
255-255: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
262-262: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
265-265: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
272-272: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
279-279: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
283-283: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
293-293: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
294-294: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
294-294: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
299-299: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
305-305: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
312-312: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
315-315: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
316-316: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
316-316: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
319-319: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
322-322: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
323-323: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
323-323: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
326-326: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
327-327: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
327-327: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
332-332: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
344-344: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
368-368: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
374-374: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
73-73: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
77-77: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
80-80: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
87-87: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
92-92: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
97-97: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
102-102: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
108-108: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
113-113: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
116-116: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
121-121: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
125-125: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
129-129: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
133-133: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
142-142: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
148-148: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
164-164: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
171-171: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
173-173: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
178-178: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
182-182: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
195-195: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
201-201: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
206-206: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
216-216: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
225-225: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
228-228: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
235-235: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
238-238: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
242-242: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
250-250: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
253-253: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
256-256: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
263-263: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
266-266: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
273-273: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
280-280: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
284-284: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
295-295: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
300-300: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
306-306: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
313-313: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
317-317: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
320-320: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
324-324: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
328-328: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
333-333: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
345-345: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
369-369: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
288-288: null (MD034, no-bare-urls)
Bare URL used
218-218: null (MD040, fenced-code-language)
Fenced code blocks should have a language specified
| This also removed `@node_modules_bin_path`, `SHAKAPACKER_NODE_MODULES_BIN_PATH`, and support for installing `Shakapacker`'s javascript package in a separate directory from the Gemfile containing `Shakapacker`'s ruby gem. | ||
|
|
There was a problem hiding this comment.
Clarify the impact of the removed features in the changelog.
The changelog entry on lines 48-49 mentions the removal of @node_modules_bin_path, SHAKAPACKER_NODE_MODULES_BIN_PATH, and the support for installing Shakapacker's JavaScript package in a separate directory. However, it would be beneficial for users if the entry also briefly explained the reason for these removals and their potential impact on existing setups. This would align with the PR's objective to clarify significant changes and help prevent confusion.
| @@ -45,6 +45,8 @@ See the [v8 Upgrade Guide](https://github.com/shakacode/shakapacker/blob/main/do | |||
| This enables support for package managers other than `yarn`, with `npm` being the default; to continue using Yarn, | |||
| specify it in `package.json` using the [`packageManager`](https://nodejs.org/api/packages.html#packagemanager) property. | |||
|
|
|||
| This also removed `@node_modules_bin_path`, `SHAKAPACKER_NODE_MODULES_BIN_PATH`, and support for installing `Shakapacker`'s javascript package in a separate directory from the Gemfile containing `Shakapacker`'s ruby gem. | |||
There was a problem hiding this comment.
Because Shakapacker no longer needs it now that package_json is being used to handle package managers (and by extension running commands), and it's not valid in all contexts e.g. Yarn Berry w/ PnP enabled doesn't have a node_modules
There was a problem hiding this comment.
I agree that this is useful to highlight but wouldn't backtrack here.
Don't think this functionality/ENV variable was ever documented so it was fair bit of tribal knowledge either way. Actually never seen it in the wild nor noticed it before
There was a problem hiding this comment.
Original and many react_on_rails projects had the client code in a client directory, including package.json.
There was a problem hiding this comment.
However, it's not hard to migrate.
There was a problem hiding this comment.
Need to mention this in the upgrade doc, and how to remedy this issue with top level package.json
| @@ -45,6 +45,8 @@ See the [v8 Upgrade Guide](https://github.com/shakacode/shakapacker/blob/main/do | |||
| This enables support for package managers other than `yarn`, with `npm` being the default; to continue using Yarn, | |||
| specify it in `package.json` using the [`packageManager`](https://nodejs.org/api/packages.html#packagemanager) property. | |||
|
|
|||
| This also removed `@node_modules_bin_path`, `SHAKAPACKER_NODE_MODULES_BIN_PATH`, and support for installing `Shakapacker`'s javascript package in a separate directory from the Gemfile containing `Shakapacker`'s ruby gem. | |||
There was a problem hiding this comment.
Need to mention this in the upgrade doc, and how to remedy this issue with top level package.json
I thought it might be best to be more explicit about this breaking change, as I spent a little time confused over it.
Currently, I only know of two organizations that relied on the removed functionality, but there could be more.
That said, I don't think the removed functionality is necessary since the only reason I can think of for splitting Shakapacker's javascript package & ruby gem between separate directories is CI caching.
Would you agree, @G-Rath?
Summary by CodeRabbit
Shakapacker.npmandyarn.