Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
  • Loading branch information
justin808 and coderabbitai[bot] authored May 16, 2024
1 parent 3e7ff83 commit cf41176
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions docs/v8_upgrade.md
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@ If your host might differ, between various environments for example, you will ei

Second option has got a certain gotcha - dynamic imports and static asset references (like image paths in CSS) will end up without host reference and the app will try and fetch them from your app host rather than defined `config.asset_host`.

Make sure the assets are compiled with `SHAKAPACKER_ASSET_HOST=''` ENV variable to avoid hardcoding URLs in packs output.

To get around that, you can use dynamic override as outlined by [Webpack documentation](https://webpack.js.org/guides/asset-modules/#on-the-fly-override).

Setting for example:
Expand Down

0 comments on commit cf41176

Please sign in to comment.