Initial Atomic<T> type implementation.
#5125
Open
+1,306
−106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffbolznv
reviewed
Sep 20, 2024
| enum MemoryOrder | ||
| { | ||
| Relaxed = $(kIRMemoryOrder_Relaxed), | ||
| SeqCst = $(kIRMemoryOrder_SeqCst), |
There was a problem hiding this comment.
FWIW Vulkan doesn't actually support sequentially consistent atomics. We do support AcquireRelease which is close, but doesn't support some obscure use cases. I think it would be fine to only have Relaxed for now.
There was a problem hiding this comment.
I see. SeqCst was added because metal supports it.
There was a problem hiding this comment.
I guess we can have AcquireRelease here and map it to SeqCst on metal.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5084.
Todo: test new Atomic type for all existing targets as well as wgsl target.