Add diagnostic to verify the left hand side of a generic constraint. #5112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csyonghe
force-pushed
the
generic-constraint-diagnostic
branch
from
b264399
to
f51876f
Compare
jkwak-work
previously approved these changes
Sep 20, 2024
| // associatedtype T | ||
| // where T : IFoo // OK, constraint is on the associatedtype T itself. | ||
| // where T.T == X; // OK, constraint is on the associated type of T. | ||
| // where int == X; // Error, int is not a valid left hand side of a constraint. |
There was a problem hiding this comment.
I think you meant to say
where int : X // Error ...
I mean that == should be replaced with : and ; should be dropped.
There was a problem hiding this comment.
== is also a valid constraint operator, for type equality constraints.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(This PR is based on top of PR #5111.)
Add validation on left hand side of type generic. For example, we need to diagnose an error for:
Closes #5113.