-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow building using external dependencies #5076
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Jacki <[email protected]>
Signed-off-by: Jacki <[email protected]>
Signed-off-by: Jacki <[email protected]>
Signed-off-by: Jacki <[email protected]>
Signed-off-by: Jacki <[email protected]>
…ier options that break the build process Signed-off-by: Jacki <[email protected]>
@expipiplus1 can you review this? I remember we have options for selecting where to source the spirv headers etc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a very useful improvement! thanks!
Signed-off-by: Jacki <[email protected]>
Signed-off-by: Jacki <[email protected]>
@expipiplus1 can you please do another round of review, thanks. |
@TheJackiMonster I made some cleanups and changes, and merged the latest version of slang, it's in my branch here, If it works for you, please merge it into your PR here and we'll merge if CI passes |
Signed-off-by: Jacki <[email protected]>
Should work for me. I just added an option to disable slang-rhi because it's only used for the But feel free to correct me if I'm wrong with this. |
Ok good, I'll take care of fixing the CI and merging from here.\ Thank you! |
I had issues building slang as submodule without fetching its dependencies recursively. So I added options to allow building slang fully with externally included targets and headers.
One example for this here:
https://github.com/TheJackiMonster/vkcv-framework/blob/develop/modules/shader_compiler/config/SLANG.cmake