-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Member-wise constructor generation with visibility control #4854
Open
ArielG-NV
wants to merge
125
commits into
shader-slang:master
Choose a base branch
from
ArielG-NV:initializer-list-visibility
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
125 commits
Select commit
Hold shift + click to select a range
40f0cbe
Member-wise constructor generation with visibility control
ArielG-NV ce554c3
Merge branch 'master' into initializer-list-visibility
ArielG-NV ceb70c4
fix bug which causes crash
ArielG-NV 6df637d
Merge branch 'initializer-list-visibility' of https://github.com/Arie…
ArielG-NV 0110058
git merge fix
ArielG-NV a1b1c50
Merge branch 'master' into initializer-list-visibility
ArielG-NV 0dca495
fix default init expr with init expr paramDecl
ArielG-NV 44de3d4
Merge branch 'initializer-list-visibility' of https://github.com/Arie…
ArielG-NV bab4c9f
Merge branch 'master' into initializer-list-visibility
ArielG-NV d82d68b
Fixes
ArielG-NV 892016a
fix bug and incorrect test
ArielG-NV 5755c0a
fix more tests with invalid init-lists
ArielG-NV f6d5bd3
fix swizzle causing a failiure with `checkExpr` to resolve an `Invoke`
ArielG-NV 251314e
Merge branch 'master' into initializer-list-visibility
ArielG-NV 045e27a
init expr with default ctor is now more restrictive due to current li…
ArielG-NV 6d50283
Merge branch 'initializer-list-visibility' of https://github.com/Arie…
ArielG-NV 4c36d3a
Revert "init expr with default ctor is now more restrictive due to cu…
ArielG-NV cbe95fb
try removing null default-ctor construction logic due to causing fail…
ArielG-NV f8bf220
undo some code removal
ArielG-NV 1e7819a
make a few additions/changes to init list logic:
ArielG-NV 1e4ec35
remove unused var
ArielG-NV 95e719d
cleanup some tests, logic and auto-documentation code
ArielG-NV 04f7177
add missing include (clang/gcc)
ArielG-NV b3d18c7
Merge branch 'master' into initializer-list-visibility
ArielG-NV 67c9d29
Clean up invalid tests, fix some bugs, add better use-site inference …
ArielG-NV 7476962
clang/gcc compiler warning
ArielG-NV 78feed6
cyclic type solution
ArielG-NV 98cd3b3
include header that defines another function (whom is in a header).
ArielG-NV a788a53
fix bit fields
ArielG-NV ff905ae
fix no_diff and trySynthesizeDifferentialAssociatedTypeRequirementWit…
ArielG-NV 89e1339
Fix how auto-diff code is auto-generated by synthed ctor's
ArielG-NV 4aced6e
remove debug code
ArielG-NV 8771a3b
Expand on automatic auto-diff modifier resolution
ArielG-NV 26908f5
fix bug related to inheritance walking introduced
ArielG-NV 75a1e7d
Merge branch 'master' into initializer-list-visibility
ArielG-NV 465e07c
cleanup and fix invalid test + refine auto-diff code
ArielG-NV 906f439
Merge branch 'master' into initializer-list-visibility
ArielG-NV f26ea60
clean-up
ArielG-NV bded32e
Merge branch 'initializer-list-visibility' of https://github.com/Arie…
ArielG-NV 5b02019
default construct structs without an initExpr (as per how Slang is su…
ArielG-NV c6acffc
Merge branch 'master' into initializer-list-visibility
ArielG-NV 3e558d7
redo reverse-addr-elim test properly without partial init
ArielG-NV 6bb3906
Merge branch 'initializer-list-visibility' of https://github.com/Arie…
ArielG-NV fd7999f
do not error if unexpected expr is found since this is not exactly 'w…
ArielG-NV 36ec8ce
auto-diff fix
ArielG-NV 8b2cbb4
Merge branch 'master' into initializer-list-visibility
ArielG-NV d88849c
undo code which should not be apart of this PR
ArielG-NV df421c5
Merge branch 'initializer-list-visibility' of https://github.com/Arie…
ArielG-NV 01274fb
change when we zero-init to stay backwards compatible
ArielG-NV c9b7080
fix warning
ArielG-NV 83af023
added a special zero-init function to handle `{}` case
ArielG-NV 969dff4
fix inheritance with zero-init-list-func and add test
ArielG-NV 5840d91
Merge branch 'master' into initializer-list-visibility
ArielG-NV dcd9081
change order of visiting
ArielG-NV 7b3fd31
Merge branch 'master' into initializer-list-visibility
ArielG-NV b1395e1
add missing auto-diff modifiers
ArielG-NV b2ce412
Merge branch 'initializer-list-visibility' of https://github.com/Arie…
ArielG-NV 23039c9
Merge branch 'master' into initializer-list-visibility
ArielG-NV c9221ea
fix syntax err
ArielG-NV f55254a
fix functor support regression
ArielG-NV d948c75
allow `{}` inside `__init()`
ArielG-NV cd1a46c
fix compile error
ArielG-NV 4403ede
fix another warning
ArielG-NV 99088c3
auto-infer generic from the base-struct type with `constructZeroInitL…
ArielG-NV 24f8c45
fix a test
ArielG-NV 25138e0
fix cyclic ref error for DefaultConstruct
ArielG-NV 93af3db
dont make reg func a `()` wrapped func
ArielG-NV c026b07
fix visibility and type issue
ArielG-NV 915b0b8
add defaults to syth'ed ctor's under special situations to allow c-st…
ArielG-NV 31c1e46
fix warning
ArielG-NV 7fe2413
Merge branch 'master' into initializer-list-visibility
ArielG-NV c270055
handle `shouldUseInitializerDirectly` differently to work better with…
ArielG-NV c883af4
Merge branch 'initializer-list-visibility' of https://github.com/Arie…
ArielG-NV de1bc55
test clean-up and additional test-case
ArielG-NV 4f6a343
remove overload logic added, replace with simple solution of proper l…
ArielG-NV 06eea82
1. Fix isCStyleCtor evaluation 2. update autodiff.slang test to moder…
ArielG-NV 9086f7e
Merge branch 'master' into initializer-list-visibility
ArielG-NV bac6c31
fix partial init list bug
ArielG-NV 759a709
Merge branch 'initializer-list-visibility' of https://github.com/Arie…
ArielG-NV fb8588e
fix the bug correctly*
ArielG-NV e5d3c6a
Merge branch 'master' into initializer-list-visibility
ArielG-NV 05d8fd8
Merge branch 'master' of https://github.com/ArielG-NV/slang into init…
ArielG-NV 39bd24d
fix some simple problems
ArielG-NV e9a9035
ignore undefined resource var's
ArielG-NV f6b1b4a
check IRNode exists before deallocating
ArielG-NV b7654d4
fix possible cyclic ref & change `_emitDefaultConstruct` so it cannot…
ArielG-NV d5c7e16
fix order of evaluation to prevent crash (not auto-diff fixes)
ArielG-NV 6ea9950
fix var check order
ArielG-NV 5712dbb
remove resource-spec change that is wrong
ArielG-NV 4956257
remove failing test as per reccomendation (#4874)
ArielG-NV 8af50a8
Merge branch 'master' into initializer-list-visibility
ArielG-NV bb3fa44
remove specialize fix, fix recursive init calls
ArielG-NV 561a9f7
Merge branch 'initializer-list-visibility' of https://github.com/Arie…
ArielG-NV 763055b
changes:
ArielG-NV d3a6604
clean up not-needed changes
ArielG-NV 1281459
clean up more unneeded overload logic
ArielG-NV 964c3e5
change around how we define ctor and zeroInit to be more flexable
ArielG-NV 0e5e5ba
heavily document and comment on this PR in-case it is handed off to a…
ArielG-NV 997d1f0
Merge branch 'master' into initializer-list-visibility
ArielG-NV 6d40ddc
fix merge error
ArielG-NV a73795b
fix up wittness table fufillment:
ArielG-NV afa8812
fix `_structHasMemberWithValue` logic
ArielG-NV f56d34a
fix bug in `_structHasMemberWithValue`
ArielG-NV 7df745d
allow wittness through inheritance (I misread the code comments)
ArielG-NV 2177db4
try to fix more interface (and such) issues with reordering declarati…
ArielG-NV 989837f
try another balance of fixes
ArielG-NV c135f85
fix bug with checking for possible values in struct
ArielG-NV 7312af1
remove one of the backup-overload-resolution-hack-cases that was adde…
ArielG-NV 92ed12a
fix incorrect overload candidate resolution
ArielG-NV 6056e40
Merge branch 'master' into initializer-list-visibility
ArielG-NV 1164d27
address autodiff failiures
ArielG-NV 37e788e
fix crash
ArielG-NV 6587a3f
fix vectors to parse correctly with `{...}`, change tests to `dxil` t…
ArielG-NV f5bbca0
remove unused func
ArielG-NV d37593a
Merge branch 'master' into initializer-list-visibility
ArielG-NV 2b4bb0d
use more accurate logic to resolve generics wrapped init-list logic
ArielG-NV 56b343b
Merge branch 'initializer-list-visibility' of https://github.com/Arie…
ArielG-NV efbca49
add old style init list support --> deprecated
ArielG-NV ba3a91d
fix now-invalid tests to be valid
ArielG-NV 22bf6f6
Merge branch 'master' into initializer-list-visibility
ArielG-NV 852bbc3
fix warning
ArielG-NV ddf061d
Merge branch 'initializer-list-visibility' of https://github.com/Arie…
ArielG-NV af2ef09
fix incorrect test
ArielG-NV e2cc233
cleanup code & comments
ArielG-NV c0e59e8
clean up and cover all cases of `{...}` failiure so that we run legac…
ArielG-NV File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like this may be due to the lookup scope of the expr isn't correct hooked up when you create the ctor call expr?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is very likely