This repository has been archived by the owner on Feb 27, 2022. It is now read-only.
feat: add 'reading-time' and word count #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@arshad are there any changes you want me to make to this PR? |
|
Sorry. I forgot to review this. I added a few comments on the issue: #3 (comment) |
shadcn
reviewed
Mar 25, 2021
| @@ -181,6 +182,11 @@ export async function getFileData(file: MdxFile): Promise<MdxFileData> { | |||
|
|
|||
| const { content, data: frontMatter } = matter(raw) | |||
|
|
|||
| const word_count = content.split(/\s+/gu).length | |||
| const reading_time = readingTime(content) | |||
| frontMatter.reading_time = reading_time | |||
There was a problem hiding this comment.
I think we should keep frontMatter as is and add readingTime to the Node interface.
See also https://github.com/ngryman/reading-time/blob/master/index.d.ts for the types.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds 'reading-time', propagating reading_time and word_count in frontMatter.
Adds test for reading_time and word_count.