feat: Added data attribute to FormLabel when field is invalid #5188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, we were setting the class `text-destructive` to the `Label` element, when the form field had invalid values. That was problematic, since it didn't allow the user to customize the style of the `Label` component. To solve this, I've added a data attribute, `data-invalid`, when the form field is invalid. The users can then use that to customize the style.
|
@frannoriega is attempting to deploy a commit to the shadcn-pro Team on Vercel. A member of the Team first needs to authorize it. |
SoyDiego
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we were setting the class
text-destructiveto theLabelelement, when the form field had invalid values.That was problematic, since it didn't allow the user to customize the style of the
Labelcomponent.To solve this, I've added a data attribute,
data-invalid, when the form field is invalid.The users can then use that to customize the style.