Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix the typo in error messages (component.jsoncomponents.json) #4977

Merged
merged 3 commits into from
Sep 27, 2024

Conversation

nsunami
Copy link
Contributor

@nsunami nsunami commented Sep 26, 2024

This PR fixes the typo in the error message where the CLI tells the user to create a component.json file (singular), instead of a components.json file (plural).

Currently, the error message for not having a components.json file reads:

✔ You need to create a component.json file to add components. Proceed?

But, I believe it should be components.json (not component.json).

I also found another place in the get-cofing file where components.json is referenced as component.json, so included it in this PR.

Hope this helps 🤞

Copy link

vercel bot commented Sep 26, 2024

@nsunami is attempting to deploy a commit to the shadcn-pro Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Collaborator

@shadcn shadcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ha! super important fix. thank you.

Copy link

vercel bot commented Sep 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
ui ⬜️ Ignored (Inspect) Visit Preview Sep 27, 2024 11:57am

@shadcn shadcn merged commit 96880e7 into shadcn-ui:main Sep 27, 2024
5 checks passed
@nsunami nsunami deleted the nami/fix-component-to-components branch September 27, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants