GHC 9.2 support. #19
Open
GHC 9.2 support. #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why not jump to 9.6? |
|
I've got some dependencies that won't install on 9.6 yet. |
sgillespie
reviewed
Nov 12, 2024
| microlens-platform ^>=0.4.3, | ||
| linear ^>=1.21, | ||
| microlens ^>=0.4.12, | ||
| microlens-platform ^>=0.4.2, |
There was a problem hiding this comment.
I don't have a problem with any of this, but maybe it would be better to use proper ranges? eg, `linear >= 1.21 && <1.23
There was a problem hiding this comment.
I misunderstood the meaning of ^>=.
Yes, I think we would need to expand that out to support 1.21 to 1.23
There was a problem hiding this comment.
Having had a bit more time, I think we should leave microlens, microlens-platform as you have done there. For linear, let's make it 1.21 && <2, since it seems to mostly use the minor version component
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just rolling back a few version numbers to support GHC 9.2.
Tests are passing with the latest ghc 9.2 lts snapshot, which I've added in a new stack config file.
Currently doing my own testing in a new project I've started.