Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always build universal binaries on macOS #1229

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

paulfd
Copy link
Member

@paulfd paulfd commented Jan 15, 2024

No description provided.

@redtide
Copy link
Member

redtide commented Jan 15, 2024

I think this is not necessary here, I thought we could make st_audiofile a standalone repo with its own CI workflow and do this there instead.

@paulfd
Copy link
Member Author

paulfd commented Jan 15, 2024

Doing both is also an option!

@redtide
Copy link
Member

redtide commented Jan 15, 2024

I still have the same idea about not to "abuse" of CI resources (after the Travis experience...). Other than that, builds are quite a lot and takes forever if there is some activity on the repo.
So if you care to set the universal build here, then forget my previous comment.

@redtide
Copy link
Member

redtide commented Jan 15, 2024

Anyway.. this is strange, disabling WAVPACK_ENABLE_ASM was working before, unless it's something different this time. Is it possible that it needs to cache the var in CMake?

@redtide
Copy link
Member

redtide commented Jan 15, 2024

Erm... my bad, I forgot about this, and also confused for some reason that the issue was on the plugins side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants