Show hopefully friendlier messages #2
+49
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since relative imports don't work with the `import <>` syntax, suggest
importing the names directly. In these cases, the `i.module` is `None`
and the `i.level` has the number of levels down in the relative import,
e.g. `1` means the current directory.
If there's only one name, suggest:
use 'import module.name' instead of 'from module import name'
This implements the enhancement proposed in sfstpala#1.
|
Tested with success in all of "py27,py34,py35,py36". |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since relative imports don't work with the
import <>syntax, suggest importing the names directly. In these cases, thei.moduleisNoneand thei.levelhas the number of levels down in the relative import, e.g.1means the current directory.If there's only one name, suggest:
This implements the enhancement proposed in #1.