This repository has been archived by the owner on Oct 14, 2024. It is now read-only.
Support explicitly specified artifacts e.g. fat JARs #92
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did you implement:
Fixes #89.
How did you implement it:
We check whether the
serverless.variables.service.package.artifact
variable exists. If it does, it gets attached to every function object. When a function is invoked, if the artifact variable is set, the artifact is unpacked with theunzip
shell command to a temporary directory.sls-simulate-unzipped
. That directory is mounted into the docker container at/var/task
. Otherwise the project root is mounted there.How can we verify it:
You can pick any JVM Serverless project, whichever is easiest for you. Here's instructions for Scala/SBT
sls create -t aws-scala-sbt -p foo
serverless.yml
with this:sbt assembly
- You'll need to have SBT installedsls simulate apigateway
curl http://localhost:3000/hello
You should see this:
Without this PR you'll get the error from #89.
Todos:
Is this ready for review?: YES