This repository has been archived by the owner on Mar 31, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 7
controller: Add relative vendor prefix by default #71
Draft
ermo
wants to merge
5
commits into
serpent-os:main
Choose a base branch
from
ermo:relative-prefix
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks like this needs a bit of design work:
NB: In normal use, full paths aren't specified, so the first hit in $PATH will be used. Hence, it will likely be useful if binaries explicitly specify their binDir in a Examples:
@ikeycode: Does ^ sound about right to you? |
This should allow e.g. /usr/local/bin/boulder to look for its configuration files in /usr/local/bin/../share/ Signed-off-by: Rune Morling <[email protected]>
Introduces configRootPrefix (was configPrefix) and vendorPrefix. configRootPrefix defaults to "/" and vendorPrefix defaults to a relativePrefix based on where this boulder instance is run from: /usr/local/bin/boulder -> vendorPrefix = /usr/local/bin/../ /usr/bin/boulder -> vendorPrefix = /usr/bin/../ If a configRootPrefix is specified on the command line, vendorPrefix is hardcoded to vendorPrefix = /usr to ensure that configurations inside moss-controlled roots are respected. configRootPrefix and vendorPrefix are passed along to moss-config, which then generates config file vendor search paths and admin override search paths. Signed-off-by: Rune Morling <[email protected]>
Signed-off-by: Rune Morling <[email protected]>
Fixes boulder exiting with code 1 after a successful build if a recipe location wasn't passed to args and boulder just built the stone.yml recipe found in the current location.
Why? - Manifest files get overridden - Needs additional logic for the exit code, i.e. build A fails and build B succeeds, what to return? exit early? - Umounting logic doesn't work correctly.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should allow e.g. /usr/local/bin/boulder to look for its configuration files in /usr/local/bin/../share/
Depends on serpent-os/libmoss#2