Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ratio limits #28

Merged
merged 13 commits into from
Oct 4, 2024
Merged

Ratio limits #28

merged 13 commits into from
Oct 4, 2024

Conversation

sepandhaghighi
Copy link
Owner

@sepandhaghighi sepandhaghighi commented Oct 3, 2024 •
edited
Loading

Reference Issues/PRs

#11

What does this implement/fix? Explain your changes.

  • Ratio upper limit added
  • Ratio lower limit added
  • check_ratio_limits function added

Any other comments?

@sepandhaghighi sepandhaghighi self-assigned this Oct 3, 2024
@sepandhaghighi sepandhaghighi added the enhancement New feature or request label Oct 3, 2024
@sepandhaghighi sepandhaghighi added this to the mycoffee v0.5 milestone Oct 3, 2024
@codecov Codecov
Copy link

codecov bot commented Oct 3, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (197e37d) to head (1654957).
Report is 1 commits behind head on dev.

Additional details and impacted files 
@@            Coverage Diff            @@
##               dev       #28   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           63        75   +12     
  Branches        13        15    +2     
=========================================
+ Hits            63        75   +12

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sepandhaghighi sepandhaghighi marked this pull request as ready for review October 3, 2024 22:31
sadrasabouri
sadrasabouri approved these changes Oct 4, 2024
View reviewed changes
Copy link
Collaborator

@sadrasabouri sadrasabouri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SG

@sadrasabouri sadrasabouri merged commit f65ae1d into dev Oct 4, 2024
46 checks passed
@sadrasabouri sadrasabouri deleted the ratio_limit branch October 4, 2024 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sadrasabouri sadrasabouri sadrasabouri approved these changes

Assignees

@sepandhaghighi sepandhaghighi

Labels
enhancement New feature or request
Projects
None yet
Milestone
mycoffee v0.5
Development

Successfully merging this pull request may close these issues.
2 participants
@sepandhaghighi @sadrasabouri