--digits argument
#25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #25 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 62 63 +1
Branches 13 13
=========================================
+ Hits 62 63 +1 ☔ View full report in Codecov by Sentry. |
sadrasabouri
approved these changes
Sep 28, 2024
README.md
Outdated
| @@ -174,6 +174,12 @@ Info: Chemex method | |||
| <td align="center">String</td> | |||
| <td align="center"><code>Custom brewing method</code></td> | |||
| </tr> | |||
| <tr> | |||
| <td align="center"><code>--digits</code></td> | |||
| <td align="center">Number of digits up to which the result is to be rounded</td> | |||
There was a problem hiding this comment.
is rounded good enough.
mycoffee/__main__.py
Outdated
| @@ -18,6 +18,11 @@ def main(): | |||
| parser.add_argument('--water-ratio', help='coefficient for the water component in the ratio', type=float) | |||
| parser.add_argument('--water', help='amount of water in each cup (gr)', type=float) | |||
| parser.add_argument('--cups', help='number of cups', type=int) | |||
| parser.add_argument( | |||
| '--digits', | |||
| help='number of digits up to which the result is to be rounded', | |||
Comment on lines
+160
to
+181
| >>> args = parser.parse_args(["--method", 'steep-and-release', "--digits", '1']) | ||
| >>> params = load_params(args) | ||
| >>> params["coffee"] = calc_coffee(params) | ||
| >>> params["water"] | ||
| 255 | ||
| >>> params["coffee"] | ||
| 15.9375 | ||
| >>> params["water_ratio"] | ||
| 16 | ||
| >>> params["coffee_ratio"] | ||
| 1 | ||
| >>> params["method"] | ||
| 'steep-and-release' | ||
| >>> params = filter_params(params) | ||
| >>> params["water_ratio"] | ||
| 16 | ||
| >>> params["coffee_ratio"] | ||
| 1 | ||
| >>> params["water"] | ||
| 255 | ||
| >>> params["coffee"] | ||
| 15.9 |
There was a problem hiding this comment.
Don't we want to add params['digits']
sadrasabouri
approved these changes
Sep 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
#9
What does this implement/fix? Explain your changes.
--digitsargument addedREADME.mdupdatedfilter_paramsfunction updatedAny other comments?