Fix broken license downloads from GitHub #89
Conversation
When a license is linked to a file on GitHub, the downloaded HTML will not be usable. Instead, detect those URLs and download the raw file instead. This file will usually be a text file and not HTML, so make sure that the correct extension is used in this case.
|
Can you please explain what you mean with "not usable"? I'm generally hesitant to include such special cases and giving an explanation that provides data will help me make a judgement call either way.... |
|
Of course! It will look like this for, for example, System.Buffers with license URL https://github.com/dotnet/corefx/blob/master/LICENSE.TXT
|
There was a problem hiding this comment.
Going through this in more detail, I think we can live with this special case, as github is such a common place to store code on and a lot of nuget packages are developed on github. However I would encourage you to add thorough unit tests for this functionality.
|
|
I just merged this PR into the main branch. This means the fix will end up in the next release. Thank you so much for your contribution @mtnpke |
|
Great, thanks! Have a nice week. |
When a license is linked to a file on GitHub, the downloaded HTML will not be usable. Instead, detect those URLs and download the raw file instead. This file will usually be a text file and not HTML, so make sure that the correct extension is used in this case.