Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added pending & failed message #363

Merged
merged 20 commits into from
Sep 25, 2024
Merged

Conversation

liamcho
Copy link
Contributor

@liamcho liamcho commented Sep 12, 2024

Changes

  • Added pending and failed messages

ticket: AC-2609

Sign.in.to.Sendbird.webm

Additional Notes

  • Tested with localCacheEnabled false, and message input disabled false

Checklist

Before requesting a code review, please check the following:

  • [Required] CI has passed all checks.
  • [Required] A self-review has been conducted to ensure there are no minor mistakes.
  • [Required] Unnecessary comments/debugging code have been removed.
  • [Required] All requirements specified in the ticket have been accurately implemented.
  • Ensure the ticket has been updated with the sprint, status, and story points.

@liamcho liamcho added the 1.8.2 label Sep 12, 2024
@liamcho liamcho requested a review from bang9 September 12, 2024 06:29
@liamcho liamcho self-assigned this Sep 12, 2024
Copy link

netlify bot commented Sep 12, 2024

Deploy Preview for chat-ai-widget ready!

Name Link
🔨 Latest commit c978e93
🔍 Latest deploy log https://app.netlify.com/sites/chat-ai-widget/deploys/66f27a36ba8db70008c988a6
😎 Deploy Preview https://deploy-preview-363--chat-ai-widget.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@liamcho liamcho removed the request for review from bang9 September 12, 2024 06:30
Copy link

github-actions bot commented Sep 12, 2024

Size Change: +227 B (+0.04%)

Total Size: 602 kB

Filename Size Change
./dist/__bundle-46d64517-********.js 4.01 kB +1 B (+0.02%)
./dist/__bundle-bbedc09c-********.js 891 B -1 B (-0.11%)
./dist/index-********.js 305 kB +41 B (+0.01%)
./dist/index.es.js 170 B -2 B (-1.16%)
./dist/index.umd.js 282 kB +139 B (+0.05%)
./dist/Placeholder.error-********.js 345 B -1 B (-0.29%)
./dist/Placeholder.noChannels-********.js 182 B -3 B (-1.62%)
./dist/Placeholder.noMessages-********.js 182 B -2 B (-1.09%)
./dist/PlaceholderCommon-********.js 246 B +2 B (+0.82%)
./dist/style.css 8.57 kB +53 B (+0.62%)
ℹ️ View Unchanged
Filename Size
./dist/__bundle-7c3d40f4-********.js 21 B
./dist/Placeholder.loading-********.js 184 B

compressed-size-action

@liamcho liamcho requested a review from bang9 September 12, 2024 06:32
@liamcho liamcho changed the title feat: Added pending message feat: Added pending & failed message Sep 12, 2024
@liamcho
Copy link
Contributor Author

liamcho commented Sep 13, 2024

Screenshot 2024-09-13 at 2 14 15 PM

깃헙이 이상하네요..

@liamcho liamcho force-pushed the feat/AC-2609-add-pending-message branch from c18ce4f to f8ea978 Compare September 13, 2024 06:35
@bang9 bang9 added 1.8.3 and removed 1.8.2 labels Sep 19, 2024
@liamcho liamcho requested a review from bang9 September 24, 2024 06:03
@liamcho liamcho requested a review from bang9 September 24, 2024 06:41
Copy link
Contributor

@bang9 bang9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@liamcho liamcho merged commit 6ed2a79 into develop Sep 25, 2024
11 checks passed
@liamcho liamcho deleted the feat/AC-2609-add-pending-message branch September 25, 2024 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants