Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle bus_call messages. #92

Merged
merged 2 commits into from
Sep 8, 2023
Merged

Handle bus_call messages. #92

merged 2 commits into from
Sep 8, 2023

Conversation

danisla
Copy link
Member

@danisla danisla commented Sep 8, 2023

Fixes #89

  • Add bus_call handler to start_pipeline which calls self.pipeline.recalculate_latency() for LATENCY type Gst messages.

While the large stream of rtpsession messages with GST_DEBUG:*2 and greater are gone, these messages appear once when the pipeline is first started. They don't seem to affect the pipeline and turning off GST_DEBUG makes them go away, just like the other messages.

0:00:14.825607089 25768 0x7f46980d3840 ERROR               GST_PADS gstpad.c:3434:gst_pad_query_latency_default:<rtpfunnel0:src> minimum latency bigger than maximum latency
0:00:14.825625584 25768 0x7f46980d3840 ERROR               GST_PADS gstpad.c:3434:gst_pad_query_latency_default:<send_rtp_sink_0:proxypad23> minimum latency bigger than maximum latency
0:00:14.825631635 25768 0x7f46980d3840 ERROR               GST_PADS gstpad.c:3434:gst_pad_query_latency_default:<sink_0:proxypad21> minimum latency bigger than maximum latency
0:00:14.825640932 25768 0x7f46980d3840 ERROR               GST_PADS gstpad.c:3434:gst_pad_query_latency_default:<rtprtxsend0:src> minimum latency bigger than maximum latency
0:00:14.825646383 25768 0x7f46980d3840 ERROR               GST_PADS gstpad.c:3434:gst_pad_query_latency_default:<bin0:src_0> minimum latency bigger than maximum latency
0:00:14.825651823 25768 0x7f46980d3840 ERROR               GST_PADS gstpad.c:3434:gst_pad_query_latency_default:<rtpsession0:send_rtp_src> minimum latency bigger than maximum latency
0:00:14.825657563 25768 0x7f46980d3840 ERROR               GST_PADS gstpad.c:3434:gst_pad_query_latency_default:<rtpbin:send_rtp_src_0> minimum latency bigger than maximum latency
0:00:14.825663484 25768 0x7f46980d3840 ERROR               GST_PADS gstpad.c:3434:gst_pad_query_latency_default:<rtp_sink:proxypad9> minimum latency bigger than maximum latency
0:00:14.825668504 25768 0x7f46980d3840 ERROR               GST_PADS gstpad.c:3434:gst_pad_query_latency_default:<rtp_sink_0:proxypad8> minimum latency bigger than maximum latency
0:00:14.825673383 25768 0x7f46980d3840 ERROR               GST_PADS gstpad.c:3434:gst_pad_query_latency_default:<srtpenc0:rtp_src_0> minimum latency bigger than maximum latency
0:00:14.825678733 25768 0x7f46980d3840 ERROR               GST_PADS gstpad.c:3434:gst_pad_query_latency_default:<clocksync_0:src> minimum latency bigger than maximum latency
0:00:14.825691336 25768 0x7f46980d3840 ERROR               GST_PADS gstpad.c:3434:gst_pad_query_latency_default:<funnel0:src> minimum latency bigger than maximum latency
0:00:14.825699351 25768 0x7f46980d3840 ERROR               GST_PADS gstpad.c:3434:gst_pad_query_latency_default:<dtlssrtpenc0:src> minimum latency bigger than maximum latency

@ehfd
Copy link
Member

ehfd commented Sep 8, 2023

Perhaps, a bus handler from webrtcbin?
Maybe worth a try.

@danisla
Copy link
Member Author

danisla commented Sep 8, 2023

Perhaps, a bus handler from webrtcbin? Maybe worth a try.

The bus handler should attach to the pipeline, not the bin.

This PR is probably good enough for now wrt to the affected issue.

The gst errors only appear when audio is enabled. However, it doesn't seem to affect the audio.

I suggest creating a new issue for those errors if needed.

@ehfd
Copy link
Member

ehfd commented Sep 8, 2023

Good enough.

@danisla danisla merged commit 162a901 into main Sep 8, 2023
8 of 9 checks passed
@danisla danisla deleted the danisla/bus-handler branch September 8, 2023 08:40
@ehfd
Copy link
Member

ehfd commented Sep 9, 2023

@danisla I think the core solution is to separate audio and video into different webrtcbins.
When they are in a single stream, the web browser causes #7, whether it is on WebRTC or WebTransport. Hence Parsec a few years ago used WASM Opus decoders (which is an old method).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gst launcher and some features
2 participants