Skip to content

Commit

Permalink
Phase out Ubuntu 18.04 (Bionic)
Browse files Browse the repository at this point in the history
  • Loading branch information
ehfd committed Aug 17, 2023
1 parent 4cadf61 commit bfdbb78
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 38 deletions.
33 changes: 2 additions & 31 deletions .github/workflows/container-publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,36 +12,7 @@ env:
REGISTRY: ghcr.io
IMAGE_NAME: selkies-project/nvidia-egl-desktop
jobs:
build-bionic:
runs-on: ubuntu-latest
permissions:
contents: read
packages: write
steps:
- name: Checkout repository
uses: actions/checkout@v3
- name: Log into registry ${{ env.REGISTRY }}
if: github.event_name != 'pull_request'
uses: docker/login-action@v2
with:
registry: ${{ env.REGISTRY }}
username: ${{ github.actor }}
password: ${{ secrets.GITHUB_TOKEN }}
- name: Extract Container metadata
id: meta
uses: docker/metadata-action@v4
with:
images: ${{ env.REGISTRY }}/${{ env.IMAGE_NAME }}
- name: Build and push Ubuntu 18.04 Container image
uses: docker/build-push-action@v3
with:
build-args: |
UBUNTU_RELEASE=18.04
context: .
push: ${{ github.event_name != 'pull_request' }}
tags: ${{ env.REGISTRY }}/${{ env.IMAGE_NAME }}:18.04
labels: ${{ steps.meta.outputs.labels }}
build-focal:
build-20.04:
runs-on: ubuntu-latest
permissions:
contents: read
Expand Down Expand Up @@ -71,7 +42,7 @@ jobs:
tags: |
${{ env.REGISTRY }}/${{ env.IMAGE_NAME }}:20.04
labels: ${{ steps.meta.outputs.labels }}
build-jammy:
build-22.04:
runs-on: ubuntu-latest
permissions:
contents: read
Expand Down
8 changes: 3 additions & 5 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
# License, v. 2.0. If a copy of the MPL was not distributed with this
# file, You can obtain one at https://mozilla.org/MPL/2.0/.

# Ubuntu release versions 22.04, 20.04, and 18.04 are supported
# Ubuntu release versions 22.04, and 20.04 are supported
ARG UBUNTU_RELEASE=22.04
ARG CUDA_VERSION=11.7.1
FROM nvcr.io/nvidia/cuda:${CUDA_VERSION}-runtime-ubuntu${UBUNTU_RELEASE}
Expand Down Expand Up @@ -132,6 +132,7 @@ RUN dpkg --add-architecture i386 && \
va-driver-all \
xserver-xorg-input-all \
xserver-xorg-video-all \
vulkan-tools \
mesa-vulkan-drivers \
libvulkan-dev \
libvulkan-dev:i386 \
Expand Down Expand Up @@ -164,8 +165,6 @@ RUN dpkg --add-architecture i386 && \
libxrandr-dev \
# Install Xvfb, packages above this line should be the same between docker-nvidia-glx-desktop and docker-nvidia-egl-desktop
xvfb && \
# Install Vulkan utilities
if [ "${UBUNTU_RELEASE}" \< "20.04" ]; then apt-get install --no-install-recommends -y vulkan-utils; else apt-get install --no-install-recommends -y vulkan-tools; fi && \
rm -rf /var/lib/apt/lists/* && \
# Configure EGL manually
mkdir -p /usr/share/glvnd/egl_vendor.d/ && \
Expand Down Expand Up @@ -286,8 +285,7 @@ Pin-Priority: -1" > /etc/apt/preferences.d/firefox-ppa && \

# Wine, Winetricks, Lutris, and PlayOnLinux, this process must be consistent with https://wiki.winehq.org/Ubuntu
ARG WINE_BRANCH=staging
RUN if [ "${UBUNTU_RELEASE}" \< "20.04" ]; then add-apt-repository -y ppa:cybermax-dexter/sdl2-backport; fi && \
mkdir -pm755 /etc/apt/keyrings && curl -fsSL -o /etc/apt/keyrings/winehq-archive.key "https://dl.winehq.org/wine-builds/winehq.key" && \
RUN mkdir -pm755 /etc/apt/keyrings && curl -fsSL -o /etc/apt/keyrings/winehq-archive.key "https://dl.winehq.org/wine-builds/winehq.key" && \
curl -fsSL -o "/etc/apt/sources.list.d/winehq-$(grep VERSION_CODENAME= /etc/os-release | cut -d= -f2).sources" "https://dl.winehq.org/wine-builds/ubuntu/dists/$(grep VERSION_CODENAME= /etc/os-release | cut -d= -f2)/winehq-$(grep VERSION_CODENAME= /etc/os-release | cut -d= -f2).sources" && \
apt-get update && apt-get install --install-recommends -y \
winehq-${WINE_BRANCH} && \
Expand Down
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ The username is `user` in both the container user account and the web authentica
```
docker run --gpus 1 -it --tmpfs /dev/shm:rw -e TZ=UTC -e SIZEW=1920 -e SIZEH=1080 -e REFRESH=60 -e DPI=96 -e CDEPTH=24 -e PASSWD=mypasswd -e WEBRTC_ENCODER=nvh264enc -e BASIC_AUTH_PASSWORD=mypasswd -p 8080:8080 ghcr.io/selkies-project/nvidia-egl-desktop:latest
```
> NOTES: The container tags available are `latest` and `22.04` for Ubuntu 22.04, `20.04` for Ubuntu 20.04, and `18.04` for Ubuntu 18.04. Replace all instances of `mypasswd` with your desired password. `BASIC_AUTH_PASSWORD` will default to `PASSWD` if unspecified. The container must not be run in privileged mode.
> NOTES: The container tags available are `latest` and `22.04` for Ubuntu 22.04, and `20.04` for Ubuntu 20.04,. Replace all instances of `mypasswd` with your desired password. `BASIC_AUTH_PASSWORD` will default to `PASSWD` if unspecified. The container must not be run in privileged mode.
The environment variable `VGL_DISPLAY` can also be passed to the container, but only do so after you understand what it implicates with VirtualGL, valid values being either `egl[n]`, or `/dev/dri/card[n]` only when `--device=/dev/dri` was used for the container.

Expand All @@ -55,7 +55,7 @@ kubectl create secret generic my-pass --from-literal=my-pass=YOUR_PASSWORD
```bash
kubectl create -f egl.yml
```
> NOTES: The container tags available are `latest` and `22.04` for Ubuntu 22.04, `20.04` for Ubuntu 20.04, and `18.04` for Ubuntu 18.04. `BASIC_AUTH_PASSWORD` will default to `PASSWD` if unspecified.
> NOTES: The container tags available are `latest` and `22.04` for Ubuntu 22.04, and `20.04` for Ubuntu 20.04. `BASIC_AUTH_PASSWORD` will default to `PASSWD` if unspecified.
Change `WEBRTC_ENCODER` to `x264enc`, `vp8enc`, or `vp9enc` when using the selkies-gstreamer interface if you are using software fallback without allocated GPUs or your GPU does not support `H.264 (AVCHD)` under the `NVENC - Encoding` section in NVIDIA's [Video Encode and Decode GPU Support Matrix](https://developer.nvidia.com/video-encode-and-decode-gpu-support-matrix-new).

Expand Down

0 comments on commit bfdbb78

Please sign in to comment.