-
Notifications
You must be signed in to change notification settings - Fork 673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unused includes #1604
Remove unused includes #1604
Conversation
Just FYI, CI is failing because that all the headers like |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #1604 +/- ##
==========================================
- Coverage 83.12% 83.10% -0.02%
==========================================
Files 276 276
Lines 46907 46907
Branches 9402 9536 +134
==========================================
- Hits 38991 38983 -8
- Misses 7060 7091 +31
+ Partials 856 833 -23
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Yes, I'm still working on this PR 🙂 |
@seladb What about also adding https://github.com/include-what-you-use/include-what-you-use after fix all of them. I don't have experience with it, but do you already know or use it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I've never used it, but I can look into it. Probably in a separate PR? |
@seladb Separate PR is better, I think. Because it might need additional config which will mix this PR. |
* Remove unused includes * Fix * Add back `cstring` where needed * Remove unused includes from examples and tutorials * Add `cstdlib` * Remove unused includes for DPDK * Remove unused includes for PF_RING * Remove one more unused include for PF_RING
No description provided.