Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Telnet coverage #1208

Merged
merged 6 commits into from
Sep 23, 2023
Merged

Improve Telnet coverage #1208

merged 6 commits into from
Sep 23, 2023

Conversation

egecetin
Copy link
Collaborator

Also converted enum to scoped

@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

Merging #1208 (2985fb8) into dev (46d1f05) will increase coverage by 0.92%.
Report is 1 commits behind head on dev.
The diff coverage is 73.91%.

@@            Coverage Diff             @@
##              dev    #1208      +/-   ##
==========================================
+ Coverage   81.70%   82.63%   +0.92%     
==========================================
  Files         157      157              
  Lines       20180    20180              
  Branches     7624     7624              
==========================================
+ Hits        16488    16675     +187     
+ Misses       3071     2885     -186     
+ Partials      621      620       -1     
Flag Coverage Δ
alpine317 70.05% <31.57%> (+1.51%) ⬆️
centos7 73.43% <31.57%> (+1.51%) ⬆️
fedora37 69.89% <31.57%> (+1.53%) ⬆️
macos-11 61.22% <34.78%> (+1.12%) ⬆️
macos-12 61.34% <34.78%> (+1.18%) ⬆️
macos-ventura 60.54% <34.78%> (+0.42%) ⬆️
mingw32 70.21% <31.57%> (+1.46%) ⬆️
mingw64 70.26% <31.57%> (+1.48%) ⬆️
npcap 83.20% <73.91%> (+1.09%) ⬆️
ubuntu1804 73.63% <42.10%> (+1.50%) ⬆️
ubuntu2004 70.75% <31.57%> (+1.54%) ⬆️
ubuntu2204 69.64% <31.57%> (+1.49%) ⬆️
ubuntu2204-icpx 59.18% <39.13%> (-0.03%) ⬇️
unittest 82.63% <73.91%> (+0.92%) ⬆️
windows-2019 83.24% <73.91%> (+1.12%) ⬆️
windows-2022 83.25% <73.91%> (+1.12%) ⬆️
winpcap 83.21% <73.91%> (+1.13%) ⬆️
zstd 72.33% <39.13%> (+0.38%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
Packet++/header/TelnetLayer.h 83.33% <ø> (ø)
Packet++/src/TelnetLayer.cpp 86.24% <73.91%> (+22.48%) ⬆️

... and 4 files with indirect coverage changes

@egecetin egecetin marked this pull request as ready for review September 22, 2023 12:33
Tests/Packet++Test/Tests/TelnetTests.cpp Outdated Show resolved Hide resolved
Tests/Packet++Test/Tests/TelnetTests.cpp Outdated Show resolved Hide resolved
Tests/Packet++Test/Tests/TelnetTests.cpp Show resolved Hide resolved
@egecetin egecetin merged commit 55f9825 into seladb:dev Sep 23, 2023
35 checks passed
@egecetin egecetin deleted the telnet-cov branch September 23, 2023 15:51
fxlb pushed a commit to fxlb/PcapPlusPlus that referenced this pull request Oct 22, 2024
* Scoped enum + improve coverage

* fix

* update equal enumclass

* fix alignment

* remove tabs

* remove trailing whitespace
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants